More Eigen GPU work, with fix for CUDA 11.4 #7

fwyzard · 2021-08-17T18:47:06Z

No description provided.

CUDA version 11.3.0 and later is more strict in accessing non-__device__ static constants from __device__ functions. Explicitly marking these constants with EIGEN_DEVICE_CONST makes them available both for host and device code.

cmsbuild · 2021-08-17T18:47:31Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch cms/master/f612df273689a19d25b45ca4f8269463207c4fee.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

fwyzard · 2021-08-17T18:54:07Z

@cmsbuild, please test for CMSSW_12_1_X/slc7_amd64_gcc11

fwyzard · 2021-08-17T18:56:48Z

@cmsbuild, please test

Mark Eigen::fix<N> as EIGEN_DEVICE_CONST so it is available both on host and device code. Mark additional methods as EIGEN_CONSTEXPR EIGEN_DEVICE_FUNC. Some require C++14 for relaxed constexpr.

fwyzard · 2021-08-17T20:58:55Z

please test

cmsbuild · 2021-08-17T20:59:01Z

Pull request #7 was updated.

fwyzard · 2021-08-17T20:59:04Z

please test for CMSSW_12_1_X/slc7_amd64_gcc11

cmsbuild · 2021-08-18T04:16:42Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddb31b/17843/summary.html
COMMIT: 2916568
CMSSW: CMSSW_12_1_X_2021-08-16-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/eigen-git-mirror/7/17843/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Cuda Device Link tmp/slc7_amd64_gcc11/src/HeterogeneousCore/CUDAUtilities/test/gpuPrefixScan_t/gpuPrefixScan_t_cudadlink.o 
>> Building binary gpuPrefixScan_t
Copying tmp/slc7_amd64_gcc11/src/HeterogeneousCore/CUDAUtilities/test/gpuPrefixScan_t/gpuPrefixScan_t to productstore area:
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/HeterogeneousCore/CUDAUtilities/test/radixSort_t.cu
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/HeterogeneousCore/CUDAUtilities/test/radixSort_t.cu: In function 'void go(bool) [with T = float; int NS = 2; U = float; LL = double]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/HeterogeneousCore/CUDAUtilities/test/radixSort_t.cu:145:15: error: array subscript 'long unsigned int[0]' is partly outside array bounds of 'float [1]' [-Werror=array-bounds]
  145 |           *k = (*k >> sh) << sh;
      |           ~~~~^~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/HeterogeneousCore/CUDAUtilities/test/radixSort_t.cu:139:6: note: while referencing 'k1'
  139 |         auto k1 = a[ind[j]];
      |      ^

fwyzard · 2021-08-18T05:16:40Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddb31b/17843/summary.html
COMMIT: 2916568
CMSSW: CMSSW_12_1_X_2021-08-16-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/eigen-git-mirror/7/17843/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

Cuda Device Link tmp/slc7_amd64_gcc11/src/HeterogeneousCore/CUDAUtilities/test/gpuPrefixScan_t/gpuPrefixScan_t_cudadlink.o
>> Building binary gpuPrefixScan_t
Copying tmp/slc7_amd64_gcc11/src/HeterogeneousCore/CUDAUtilities/test/gpuPrefixScan_t/gpuPrefixScan_t to productstore area:
>> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/HeterogeneousCore/CUDAUtilities/test/radixSort_t.cu
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/HeterogeneousCore/CUDAUtilities/test/radixSort_t.cu: In function 'void go(bool) [with T = float; int NS = 2; U = float; LL = double]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/HeterogeneousCore/CUDAUtilities/test/radixSort_t.cu:145:15: error: array subscript 'long unsigned int[0]' is partly outside array bounds of 'float [1]' [-Werror=array-bounds]
145 | *k = (*k >> sh) << sh;
| ~~~~^~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/HeterogeneousCore/CUDAUtilities/test/radixSort_t.cu:139:6: note: while referencing 'k1'
139 | auto k1 = a[ind[j]];
| ^

Looks like cms-sw/cmssw#34918 is fixed.

cmsbuild · 2021-08-18T06:52:23Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddb31b/17842/summary.html
COMMIT: 2916568
CMSSW: CMSSW_12_1_X_2021-08-17-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/eigen-git-mirror/7/17842/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3205 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000352
DQMHistoTests: Total failures: 8557
DQMHistoTests: Total nulls: 2
DQMHistoTests: Total successes: 2991771
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: found differences in 1 / 38 workflows

fwyzard · 2021-08-18T07:43:29Z

please test with cms-sw/cmssw#34929 for CMSSW_12_1_X/slc7_amd64_gcc11

cmsbuild · 2021-08-18T15:18:12Z

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddb31b/17852/summary.html
COMMIT: 2916568
CMSSW: CMSSW_12_1_X_2021-08-16-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/eigen-git-mirror/7/17852/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddb31b/17852/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddb31b/17852/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/L1Trigger/DTTrigger/src/DTTrig.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/L1Trigger/DTTrigger/src/DTTrigProd.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/L1Trigger/DTTrigger/src/DTTrigTest.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/L1Trigger/DTTrigger/src/SealModule.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/L1Trigger/DTTrigger/src/DTTrigTest.cc: In member function 'virtual void DTTrigTest::beginRun(const edm::Run&, const edm::EventSetup&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/L1Trigger/DTTrigger/src/DTTrigTest.cc:198:23: error: 'this' pointer is null [-Werror=nonnull]
  198 |     my_trig->createTUs(iEventSetup);
      |     ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/L1Trigger/DTTrigger/interface/DTTrigTest.h:26,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/L1Trigger/DTTrigger/src/DTTrigTest.cc:17:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-16-1100/src/L1Trigger/DTTrigger/interface/DTTrig.h:78:8: note: in a call to non-static member function 'void DTTrig::createTUs(const edm::EventSetup&)'

fwyzard · 2021-08-18T15:19:58Z

Looks like cms-sw/cmssw#34918 and cms-sw/cmssw#34917 are both fixed.

smuzaffar · 2021-08-18T15:21:31Z

please test
lets retest based on newer IB ( do not know why there are too many comparison diffs)

cmsbuild · 2021-08-18T22:35:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddb31b/17861/summary.html
COMMIT: 2916568
CMSSW: CMSSW_12_1_X_2021-08-18-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/eigen-git-mirror/7/17861/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3000352
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000324
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

smuzaffar · 2021-08-20T08:14:35Z

+externals
looks good to go

cmsbuild · 2021-08-20T08:14:53Z

This pull request is fully signed and it will be integrated in one of the next cms/master/f612df273689a19d25b45ca4f8269463207c4fee IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

fwyzard added 2 commits August 17, 2021 20:45

Mark more functions as EIGEN_DEVICE_FUNC, support PartialPivLU::solve()

7aabe64

cmsbuild added externals-pending orp-pending pending-signatures tests-pending labels Aug 17, 2021

fwyzard mentioned this pull request Aug 17, 2021

[GCC11] RecoPixelVertexing/PixelTrackFitting error: identifier "Eigen::fix<(int)-1> " is undefined in device code cms-sw/cmssw#34918

Closed

cmsbuild added tests-started and removed tests-pending labels Aug 17, 2021

This comment has been minimized.

Sign in to view

cmsbuild added tests-rejected and removed tests-started labels Aug 17, 2021

Make fix<N> available also on GPU devices

2916568

Mark Eigen::fix<N> as EIGEN_DEVICE_CONST so it is available both on host and device code. Mark additional methods as EIGEN_CONSTEXPR EIGEN_DEVICE_FUNC. Some require C++14 for relaxed constexpr.

fwyzard force-pushed the cms/master/f612df273689a19d25b45ca4f8269463207c4fee_fix_for_CUDA_11.3 branch from df554ae to 2916568 Compare August 17, 2021 20:58

cmsbuild added tests-started and removed tests-rejected labels Aug 17, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 18, 2021

fwyzard mentioned this pull request Aug 18, 2021

Fix radix sort test cms-sw/cmssw#34929

Merged

cmsbuild added the requires-external label Aug 18, 2021

cmsbuild added tests-started and removed requires-external tests-approved labels Aug 18, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 18, 2021

smuzaffar merged commit 2b04365 into cms-externals:cms/master/f612df273689a19d25b45ca4f8269463207c4fee Aug 20, 2021

cmsbuild added externals-approved fully-signed and removed pending-signatures externals-pending labels Aug 20, 2021

smuzaffar mentioned this pull request Aug 20, 2021

[Eigen] More Eigen GPU work, with fix for CUDA 11.4 cms-sw/cmsdist#7223

Merged

fwyzard deleted the cms/master/f612df273689a19d25b45ca4f8269463207c4fee_fix_for_CUDA_11.3 branch August 22, 2021 22:39

More Eigen GPU work, with fix for CUDA 11.4 #7

More Eigen GPU work, with fix for CUDA 11.4 #7

Uh oh!

Conversation

fwyzard commented Aug 17, 2021

Uh oh!

cmsbuild commented Aug 17, 2021

Uh oh!

fwyzard commented Aug 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fwyzard commented Aug 17, 2021

Uh oh!

This comment has been minimized.

fwyzard commented Aug 17, 2021

Uh oh!

cmsbuild commented Aug 17, 2021

Uh oh!

fwyzard commented Aug 17, 2021

Uh oh!

cmsbuild commented Aug 18, 2021

Build

Uh oh!

fwyzard commented Aug 18, 2021

Build

Uh oh!

cmsbuild commented Aug 18, 2021

Comparison Summary

Uh oh!

fwyzard commented Aug 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Aug 18, 2021

Build

Uh oh!

fwyzard commented Aug 18, 2021

Uh oh!

smuzaffar commented Aug 18, 2021

Uh oh!

cmsbuild commented Aug 18, 2021

Comparison Summary

Uh oh!

smuzaffar commented Aug 20, 2021

Uh oh!

cmsbuild commented Aug 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fwyzard commented Aug 17, 2021 •

edited

Loading

fwyzard commented Aug 18, 2021 •

edited

Loading