Ids fs #3
Open
Ids fs #3
+613
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sam,
As we discussed, I have now ported changes from Francesco M. and Vinzenz Stampf. It was good to see that the base was there - only a few debugs + porting to EgammaPostRecoTools.
I started with the CMSDAS2020 version of EgammaPostRecoTools.py which I assume had Jonas's last commits and my UL scale/smearing updates.
Here is the setup needed:
https://github.com/jainshilpi/cmssw/tree/IDSFs
and the slides from the main developers: https://indico.cern.ch/event/842077/contributions/3633040/attachments/1941671/3219683/egm_08Nov19.pdf
Files added:
(1) RecoEgamma/EgammaTools/plugins/EGammaSFModifier.cc
(2) RecoEgamma/EgammaTools/plugins/json_wrapper.cc
(3) RecoEgamma/EgammaTools/interface/json_wrapper.h
(4) ecoEgamma/EgammaTools/data/run2_PhoIDs.json
(5) ecoEgamma/EgammaTools/data/run2_EleIDs.json
Code modified:
(1) RecoEgamma/EgammaTools/python/egammaObjectModificationsInMiniAOD_cff.py
This currently gives only 1 set of ele and pho SFs at a time.
Probably EgammaPostRecoTools can be adapted to run this for several
SFs in loop?
The EgammaPostRecoTools is setup to deal with UL2017 and UL2018 ID SFs.
The remaining : ele reco SFs and photon veto SFs are still needed to be done.
I think the setup can be improved e.g. json_wrapper.cc can be modified a bit by giving the input json file name to
constructor.
Please let me know if you have any suggestions to it.
For now, this setup works and printouts give expected result. We need to just plot the 2D SF plot in one go to be sure of all the pT, eta and ID bins.
Thanks,
Shilpi
Setup to convert to JSON: https://github.com/cms-egamma/json_converter_egID