Skip to content

Conversation

@mmasciov
Copy link
Contributor

As per title.
In addition, a JSON for highPtTripletStep in phase-2 is added, in view of further, future developments.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmasciov for branch main.

@akritkbehera, @cmsbuild, @iarspider, @jfernan2, @mandrenguyen, @smuzaffar, @srimanob can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2025

cms-bot internal usage

@mmusich
Copy link

mmusich commented Nov 13, 2025

test parameters:

@mmusich
Copy link

mmusich commented Nov 13, 2025

@cmsbuild, please test

@mmusich
Copy link

mmusich commented Nov 13, 2025

In addition, a JSON for highPtTripletStep in phase-2 is added, in view of further, future developments.

@mmasciov for my own education is the additional json file forseen to be used for offline tracking?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18dd46/49447/summary.html
COMMIT: e19729f
CMSSW: CMSSW_16_0_X_2025-11-13-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/RecoTracker-MkFit/19/49447/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3911086
  • DQMHistoTests: Total failures: 573
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3910493
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 221 log files, 190 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@mmasciov
Copy link
Contributor Author

In addition, a JSON for highPtTripletStep in phase-2 is added, in view of further, future developments.

@mmasciov for my own education is the additional json file forseen to be used for offline tracking?

That's correct: it's just meant to facilitate mkFit developers in the context of future offline-oriented developments.

@mmasciov
Copy link
Contributor Author

please test

(for completeness, as cms-sw/cmssw#49383 was updated)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18dd46/49459/summary.html
COMMIT: e19729f
CMSSW: CMSSW_16_0_X_2025-11-13-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/RecoTracker-MkFit/19/49459/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18dd46/49459/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18dd46/49459/git-merge-result

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3911086
  • DQMHistoTests: Total failures: 1447
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 3909614
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 221 log files, 190 edm output root files, 52 DQM output files
  • TriggerResults: found differences in 1 / 50 workflows

@mmusich
Copy link

mmusich commented Nov 17, 2025

That's correct: it's just meant to facilitate mkFit developers in the context of future offline-oriented developments.

thanks for the clarification.

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @mandrenguyen, @ftenchini: This PR was tested with cms-sw/cmssw#49383, please check if they should be merged together

@mmusich
Copy link

mmusich commented Nov 19, 2025

@jfernan2 @iarspider can you sign this one too given that cms-sw/cmssw#49383 has converged?

@mandrenguyen
Copy link

merge

@cmsbuild cmsbuild merged commit 648f883 into cms-data:main Nov 20, 2025
10 checks passed
@mandrenguyen
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants