Skip to content

Conversation

@minxiyang
Copy link

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @minxiyang (Minxi Yang) for branch master.

@smuzaffar, @iarspider, @cmsbuild, @slava77, @jpata, @ddaina can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@minxiyang
Copy link
Author

Upload new DNNs trained with CKF tracks and MkFit 4+3 tracks.

@slava77
Copy link

slava77 commented Oct 15, 2021

@minxiyang

similar to suggestions in #9 please use less generic names to specify the era or version together with some details of how the files were created in the README.md file.
Thank you.

@JanFSchulte
Copy link

For reference, these DNNs go with the update of the track selection via DNN for both CKF and mkFit tracks in cms-sw/cmssw#35686

@slava77
Copy link

slava77 commented Oct 18, 2021

@minxiyang

similar to suggestions in #9 please use less generic names to specify the era or version together with some details of how the files were created in the README.md file. Thank you.

can this update be done soon?

@cmsbuild
Copy link
Contributor

Pull request #10 was updated.

@slava77
Copy link

slava77 commented Oct 20, 2021

@minxiyang
it looks like in the last update new/renamed files were added but the original ones were not removed.

Please cleanup.

A rebase with history cleanup to remove TrackTfClassifier/CKF_dnn.pb and TrackTfClassifier/MkFit_4plus3_dnn.pb is preferred
(the TrackTfClassifier/CKF_2021Run3.pb and TrackTfClassifier/MkFit4plus3_2021Run3.pb will remain)

@cmsbuild
Copy link
Contributor

Pull request #10 was updated.

@slava77
Copy link

slava77 commented Oct 20, 2021

+reconstruction

this adds new files and can be merged first, before we converge on signing cms-sw/cmssw#35686

The quality/content of the files was tested more extensively within TRK POG.
The cms-sw/cmssw#35686 runs with these files OK.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18d5b2/19785/summary.html
COMMIT: 0e737e0
CMSSW: CMSSW_12_1_X_2021-10-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/RecoTracker-FinalTrackSelectors/10/19785/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1008 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 2751113
  • DQMHistoTests: Total failures: 2574
  • DQMHistoTests: Total nulls: 62
  • DQMHistoTests: Total successes: 2748455
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 65.355 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 140.53 ): 63.680 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): 1.676 KiB RPC/DCSInfo
  • Checked 170 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link

slava77 commented Oct 22, 2021

@qliphy @perrotta
were you planning to merge this?
It may simplify the ordering relative to merging #35686

@smuzaffar
Copy link
Contributor

+externals
Only new files

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link

+1

  • New files added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants