-
Notifications
You must be signed in to change notification settings - Fork 5
upload new dnn #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upload new dnn #10
Conversation
|
A new Pull Request was created by @minxiyang (Minxi Yang) for branch master. @smuzaffar, @iarspider, @cmsbuild, @slava77, @jpata, @ddaina can you please review it and eventually sign? Thanks. |
|
Upload new DNNs trained with CKF tracks and MkFit 4+3 tracks. |
|
similar to suggestions in #9 please use less generic names to specify the era or version together with some details of how the files were created in the README.md file. |
|
For reference, these DNNs go with the update of the track selection via DNN for both CKF and mkFit tracks in cms-sw/cmssw#35686 |
can this update be done soon? |
|
Pull request #10 was updated. |
|
@minxiyang Please cleanup. A rebase with history cleanup to remove TrackTfClassifier/CKF_dnn.pb and TrackTfClassifier/MkFit_4plus3_dnn.pb is preferred |
|
Pull request #10 was updated. |
|
+reconstruction this adds new files and can be merged first, before we converge on signing cms-sw/cmssw#35686 The quality/content of the files was tested more extensively within TRK POG. |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18d5b2/19785/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
|
+externals |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1
|
No description provided.