Skip to content

Conversation

@felicepantaleo
Copy link
Contributor

Update the energy regression and pid DNN.
Results were shown in Reco Meeting:
https://indico.cern.ch/event/1187388/contributions/4989483/attachments/2490125/4276212/TICLv4_RECO_Meeting_5Aug2022.pdf

To be tested together with an upcoming PR in cmssw.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2022

A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for branch master.

@smuzaffar, @aandvalenzuela, @iarspider, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @jpata, @mandrenguyen can you please review it and eventually sign? Thanks.
@youyingli, @forthommel, @rovere, @apsallid, @sobhatta, @lecriste, @hatakeyamak, @trtomei, @ebrondol, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@felicepantaleo
Copy link
Contributor Author

felicepantaleo commented Sep 1, 2022

@waredjeb @rovere fyi

@felicepantaleo
Copy link
Contributor Author

@cmsbuild please test with cms-sw/cmssw#39302

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2022

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99c889/27315/summary.html
COMMIT: 7c1218a
CMSSW: CMSSW_12_6_X_2022-09-04-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/RecoHGCal-TICL/4/27315/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99c889/27315/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99c889/27315/git-merge-result

RelVals-INPUT

  • 138.2138.2_ExpressCosmics+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3/step2_ExpressCosmics+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3.log
  • 138.1138.1_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3/step2_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3.log

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 67670 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3618210
  • DQMHistoTests: Total failures: 443010
  • DQMHistoTests: Total nulls: 372
  • DQMHistoTests: Total successes: 3174806
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4.79 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.181 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): 0.059 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 6.566 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -1.537 KiB SiStrip/MechanicalView
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 16 / 50 workflows

@felicepantaleo
Copy link
Contributor Author

@perrotta are the tests executed here the same as cms-sw/cmssw#39302 (comment) ?

@perrotta
Copy link

perrotta commented Sep 5, 2022

@perrotta are the tests executed here the same as cms-sw/cmssw#39302 (comment) ?

Yes, even if based on a different IB and with a different list of accompanying PRs tested together
The RelVal Input failures notified here do not depend on the tested PR, and are also presented sporadically in other PR tests

@AdrianoDee
Copy link

@cmsbuild please test with cms-sw/cmssw#39302

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99c889/27520/summary.html
COMMIT: 7c1218a
CMSSW: CMSSW_12_6_X_2022-09-13-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/RecoHGCal-TICL/4/27520/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99c889/27520/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99c889/27520/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8686 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3618326
  • DQMHistoTests: Total failures: 20184
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3598120
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link

@clacaputo
Copy link

+reconstruction

@perrotta
Copy link

@perrotta
Copy link

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants