Skip to content

Conversation

@bainbrid
Copy link
Contributor

@bainbrid bainbrid commented Apr 30, 2021

UPDATED:

This PR adds two weights files, on the V01-01-XX branch for the 10_6_X release cycle:

  • LowPtElectrons_ID_2020Nov28.root
  • LowPtElectrons_ID_2021May17.root

in addition to the existing LowPtElectrons_ID_2020Sept15.root weights file, as required by the PR cms-sw/cmssw#33589

The 2020Sept15 file is already in use by the run2_miniAOD_UL modifier for the ongoing UL re-miniAOD campaign.

The 2020Nov28 is enabled by the run2_miniAOD_devel modifier, to used during any future UL re-MINIAOD campaign for "standard" CMS data sets.

The 2021May17 file is enabled by the bParking modifier, to used during the UL RE-RECO of the BParking data set.

The model performances can be found in this presentation.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bainbrid for branch V01-01-XX.

@perrotta, @smuzaffar, @mrodozov, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @lgray, @sobhatta, @afiqaize, @varuns23, @ram1123 this is something you requested to watch as well.
cms-bot commands are listed here

@mrodozov
Copy link

please test with cms-sw/cmssw#33589

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5af1ca/14748/summary.html
COMMIT: 4e71b90
CMSSW: CMSSW_10_6_X_2021-04-30-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/RecoEgamma-ElectronIdentification/19/14748/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 102 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215544
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215209
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar changed the base branch from V01-01-XX to CMSSW_10_6_X May 4, 2021 06:32
@cmsbuild
Copy link
Contributor

Pull request #19 was updated.

@bainbrid bainbrid changed the title LowPtElectrons: add 2020Nov28 model for 10_6_X LowPtElectrons: 2020Nov28 and 2021May17 models for 10_6_X May 27, 2021
@slava77
Copy link

slava77 commented Jun 2, 2021

+1

based on tests in 11X or 12X:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5af1ca/15536/summary.html
COMMIT: 77a6dca
CMSSW: CMSSW_12_0_X_2021-06-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/RecoEgamma-ElectronIdentification/19/15536/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2650486
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2650457
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@mrodozov
Copy link

mrodozov commented Jun 2, 2021

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants