Skip to content

Conversation

@sbein
Copy link
Contributor

@sbein sbein commented Aug 9, 2025

Associated PR for cms-sw/cmssw#48587

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2025

A new Pull Request was created by @sbein for branch master.

@akritkbehera, @cmsbuild, @ftorrresd, @hqucms, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 9, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

REMINDER @ftenchini, @sextonkennedy, @mandrenguyen: This PR was tested with cms-sw/cmssw#48587, please check if they should be merged together

@ftorrresd
Copy link

I'm not very familiar with this repo. Since cms-sw/cmssw#48587 is good to go, do we need any tests here, or a "+xpog" is sufficient?

@kpedro88
Copy link

test parameters:
pull_request = cms-sw/cmssw#48587

@kpedro88
Copy link

please test

@kpedro88
Copy link

@ftorrresd this one will also need to be signed, but let's get the test approval too

@ftorrresd
Copy link

@kpedro88 -- Does this one also need backports?

@kpedro88
Copy link

Yes, this one will have to be backported along with the CMSSW PR.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-343f7c/49450/summary.html
COMMIT: b50e9a2
CMSSW: CMSSW_16_0_X_2025-11-13-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/PhysicsTools-NanoAOD/20/49450/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-343f7c/49450/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-343f7c/49450/git-merge-result

Comparison Summary

Summary:

  • You potentially added 13 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 34 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3880468
  • DQMHistoTests: Total failures: 176
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3880272
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link

+1

@mandrenguyen
Copy link

merge

@cmsbuild cmsbuild merged commit afb32b3 into cms-data:master Nov 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants