-
Notifications
You must be signed in to change notification settings - Fork 3
Remove depreciated GBDT_default.onnx #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
A new Pull Request was created by @Chriisbrown for branch main. @aandvalenzuela, @aloeliger, @cmsbuild, @epalencia, @iarspider, @smuzaffar, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
please test using addpkg L1Trigger/TrackTrigger |
|
is this PR still needed? |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5569e2/46962/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
Yes this PR is still needed, the onnx model is depreciated and should be removed |
|
Hi, this PR has now taken 1 year to merge, despite not needing any corrections. I have the impression that merge procedures for cms-data are someone broken. It's common they take this long. |
|
please test using full cmssw lets fresh tests using full cmssw |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5569e2/49756/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
This PR removes the depreciated ONNX model that is no longer in use as of CMSSW 14_0_0 in order to clean up and simplify the cms-data repo and prevent the older model being used in the future.