Skip to content

Conversation

@Chriisbrown
Copy link
Contributor

This PR removes the depreciated ONNX model that is no longer in use as of CMSSW 14_0_0 in order to clean up and simplify the cms-data repo and prevent the older model being used in the future.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Chriisbrown for branch main.

@aandvalenzuela, @aloeliger, @cmsbuild, @epalencia, @iarspider, @smuzaffar, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 18, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor

please test using addpkg L1Trigger/TrackTrigger

@smuzaffar
Copy link
Contributor

is this PR still needed?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5569e2/46962/summary.html
COMMIT: 3d482bb
CMSSW: CMSSW_15_1_X_2025-06-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-TrackTrigger/5/46962/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5569e2/46962/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5569e2/46962/git-merge-result

Comparison Summary

Summary:

@Chriisbrown
Copy link
Contributor Author

is this PR still needed?

Yes this PR is still needed, the onnx model is depreciated and should be removed

@tomalin
Copy link

tomalin commented Jul 8, 2025

Hi, this PR has now taken 1 year to merge, despite not needing any corrections. I have the impression that merge procedures for cms-data are someone broken. It's common they take this long.

@smuzaffar
Copy link
Contributor

please test using full cmssw

lets fresh tests using full cmssw

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5569e2/49756/summary.html
COMMIT: 3d482bb
CMSSW: CMSSW_16_0_X_2025-12-01-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-TrackTrigger/5/49756/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5569e2/49756/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5569e2/49756/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 187 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4269233
  • DQMHistoTests: Total failures: 97
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4269116
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants