Skip to content

Conversation

@cerminar
Copy link
Contributor

@cerminar cerminar commented Apr 5, 2023

Add BDT model to the data of the package.

Tagging @aloeliger to keep him informed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2023

A new Pull Request was created by @cerminar for branch master.

@smuzaffar, @epalencia, @aandvalenzuela, @iarspider, @cmsbuild, @AdrianoDee, @srimanob, @aloeliger, @cecilecaillol can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@aloeliger
Copy link
Contributor

+l1

@AdrianoDee
Copy link

+upgrade

@AdrianoDee
Copy link

please test with cms-sw/cmssw#41647

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27f285/32639/summary.html
COMMIT: 48ad1b2
CMSSW: CMSSW_13_2_X_2023-05-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-Phase2L1ParticleFlow/6/32639/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27f285/32639/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-27f285/32639/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 15 lines from the logs
  • Reco comparison results: 63076 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3461474
  • DQMHistoTests: Total failures: 157570
  • DQMHistoTests: Total nulls: 247
  • DQMHistoTests: Total successes: 3303635
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -3.9050000000000002 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 11834.0 ): -2.354 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.404 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.426 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 0.125 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -1.537 KiB SiStrip/MechanicalView
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 17 / 46 workflows

@makortel
Copy link

cms-sw/cmssw#41290 was merged without this PR, and now a unit test in SLHCUpgradeSimulations/Geometry seems to be failing because of that.

@perrotta
Copy link

+1

@perrotta
Copy link

merge

@cmsbuild cmsbuild merged commit db24a38 into cms-data:master May 19, 2023
@perrotta
Copy link

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants