Skip to content

Add KMTF LUT #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zhenbinwu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add KMTF LUT #1

zhenbinwu wants to merge 1 commit into from

Conversation

@zhenbinwu
Copy link

@zhenbinwu zhenbinwu commented May 7, 2024

Initial

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

A new Pull Request was created by @zhenbinwu for branch main.

@epalencia, @smuzaffar, @cmsbuild, @aloeliger, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024 •
edited
Loading

cms-bot internal usage

@epalencia
Copy link

epalencia commented May 7, 2024

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c42a93/39285/summary.html
COMMIT: 8ab0d9d
CMSSW: CMSSW_14_1_X_2024-05-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-Phase2L1GMT/1/39285/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • You potentially added 17 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3332476
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3332450
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@zhenbinwu
Copy link
Author

zhenbinwu commented May 10, 2024

The test-das-selected-lumis seems not relevant to this PR: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c42a93/39285/unitTests/src/Configuration/PyReleaseValidation/test/test-das-selected-lumis/testing.log

Am I missing something? Thanks

@epalencia
Copy link

epalencia commented May 10, 2024

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 10, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c42a93/39340/summary.html
COMMIT: 8ab0d9d
CMSSW: CMSSW_14_1_X_2024-05-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-Phase2L1GMT/1/39340/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@zhenbinwu
Copy link
Author

zhenbinwu commented May 31, 2024

Hi, since this PR passed the test, could it be merged? So that the GMT PR can move forward. Many thanks!

@zhenbinwu
Copy link
Author

zhenbinwu commented Jun 21, 2024

@aloeliger Can you please sign off this PR as well? So that I can move the root file to CMS-data. Thanks

@aloeliger
Copy link

aloeliger commented Jun 21, 2024

+l1

@smuzaffar
Copy link

smuzaffar commented Jun 27, 2025

hi, is this still needed? This PR just adds a new root data file so non of the existing tests use it, is there any cmssw PR which makes use of this root file?

@zhenbinwu
Copy link
Author

zhenbinwu commented Jun 27, 2025

I think we were requested to move our data here. Once the data is stored in, we will start to move the LUTs here. Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c42a93/46961/summary.html
COMMIT: 8ab0d9d
CMSSW: CMSSW_15_1_X_2025-06-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-Phase2L1GMT/1/46961/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c42a93/46961/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c42a93/46961/git-merge-result

Comparison Summary

Summary:

@smuzaffar
Copy link

smuzaffar commented Dec 2, 2025

please test

lets refresh the tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c42a93/49755/summary.html
COMMIT: 8ab0d9d
CMSSW: CMSSW_16_0_X_2025-12-01-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-Phase2L1GMT/1/49755/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c42a93/49755/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c42a93/49755/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 14 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4269233
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4269204
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

externals-pending l1-approved orp-pending pending-signatures tests-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zhenbinwu @cmsbuild @epalencia @aloeliger @smuzaffar