Skip to content

Conversation

@jbsauvan
Copy link
Contributor

  • Add map of modules to towers in order to share module energies into several intersecting towers

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for branch master.

@smuzaffar, @epalencia, @aandvalenzuela, @iarspider, @cmsbuild, @AdrianoDee, @srimanob, @aloeliger can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@aloeliger
Copy link

@jbsauvan Could I quiz you a little bit on what this is and what it is intended for? I don't see any other tower mapping off this type present yet.

@aloeliger
Copy link

Ahh, okay, I see cms-sw/cmssw#42246 now. Nevermind.

@aloeliger
Copy link

+l1

@rappoccio
Copy link

please test

  • Refreshing tests.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbf2a1/34714/summary.html
COMMIT: 6db333f
CMSSW: CMSSW_13_3_X_2023-09-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-L1THGCal/24/34714/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 29 lines from the logs
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3348561
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3348530
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link

+Upgrade

@rappoccio
Copy link

+1

@rappoccio
Copy link

merge

@cmsbuild cmsbuild merged commit e47a20b into cms-data:master Sep 14, 2023
@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants