Skip to content

Conversation

@elfontan
Copy link
Contributor

A full set of xml files for the L1 emulation of prescales and masks coherent with the updated L1 menu for Run 3 has been created. The current version of the updated L1 Menu can be found in [1]: L1Menu_Collisions2022_v0_1_5.
In the context of the trigger studies for the preparation of the Run 3 menu (L1+HLT), we recently faced an issue related to the emulation of the L1 prescales. Two different issues were found out:

  • format of the PS table (some documentation and a recipe can be found here);
  • usage of the fractional PS (PR#37046).

Once that these new files are available here, a PR to update the PrescalesVetosFract_cff.py file will be prepared.

[1]
https://github.com/cms-l1-dpg/L1MenuRun3/tree/master/preliminary/L1Menu_Collisions2022_v0_1_5

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @elfontan (Elisa Fontanesi) for branch master.

@smuzaffar, @epalencia, @iarspider, @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@elfontan elfontan changed the title Inclusion of a new set of xml file compatible with the updated L1 menu for Run 3 Inclusion of a new set of xml files compatible with the updated L1 menu for Run 3 Feb 28, 2022
…t with the L1 menu for Run 3: added a column of 1
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2022

Pull request #8 was updated.

…t with the L1 menu for Run 3: moved PS of latest added seeds to 0 as default
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2022

Pull request #8 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2022

Pull request #8 was updated.

@elfontan
Copy link
Contributor Author

elfontan commented Mar 3, 2022

The PR has been updated including a set of files compatible with an updated version of the L1 menu: L1Menu_Collisions2022_v0_1_6.
The corresponding tag in condDB can be found here: L1Menu_Collisions2022_v0_1_6_xml.

@epalencia
Copy link

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a8e19/22929/summary.html
COMMIT: b530d29
CMSSW: CMSSW_12_3_X_2022-03-07-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-L1TGlobal/8/22929/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 347 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3985363
  • DQMHistoTests: Total failures: 300
  • DQMHistoTests: Total nulls: 9
  • DQMHistoTests: Total successes: 3985032
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 94.298 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 12.579 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 136.8523 ): 6.245 KiB Physics/NanoAODDQM
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@epalencia
Copy link

+l1

@smuzaffar
Copy link
Contributor

@elfontan these are all new data files. Is there any cms-sw/cmssw pull request which uses these files?

@elfontan
Copy link
Contributor Author

elfontan commented Mar 9, 2022

Dear @smuzaffar,
the CMSSW PR that uses these files would be this one:
cms-sw/cmssw#37138.
It is still a draft PR because I wanted to wait for these files available here before proceeding.

@smuzaffar
Copy link
Contributor

smuzaffar commented Mar 9, 2022

thanks @elfontan but looks like non of the PR tests are actually using the new files otherwise PR tests for httpshttps://github.com/cms-sw/cmssw/pull/37138 should have failed. Are there any runTheMatrix.py workflows which actually use these files?

@elfontan
Copy link
Contributor Author

Dear @smuzaffar,
sorry for my late reply!
You are right, the new files are not used in any standard workflow.
They would be used for the re-emulation of the L1 prescales and masks when applying a dedicated recipe that you can find e.g. here. The specific script that calls those two configuration files containing the new files is hackConditions_cff.py.

We would like to have these files updated just for clarity and coherence with what we are going to use (in terms of menu and prescales) as default for Run 3. (Most likely these files will be updated again by the end of the month, so we can also consider to postpone this point - but having it clarified by the preparation of CMSSW_12_3_0).
Please let me know if something is unclear and how we can eventually handle the validation in this kind of situations, if it is needed.

Cheers,
--Elisa

@smuzaffar
Copy link
Contributor

+externals

sounds good @elfontan . I am merging this now and these new files should be available in next CMSSW_12_4_X IB . If you need to get these files back ported to 12.3.X then please open a github issue for cms-sw/cmssw repository

@smuzaffar smuzaffar merged commit 9b1c09e into cms-data:master Mar 16, 2022
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@elfontan
Copy link
Contributor Author

Hello @smuzaffar,
thank you, also for precising about the need of a backport to have them in CMSSW_12_3_X.
I will probably open a github issue for this, unless we expect a update of these files very quickly, and in this case I will update these files and ask you for the backport only once (by the timeline of CMSSW_12_3_0, deadline Apr 8).

Cheers,
--Elisa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants