-
Notifications
You must be signed in to change notification settings - Fork 3
Inclusion of a new set of xml files compatible with the updated L1 menu for Run 3 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…t with L1Menu_Collisions2022_v0_1_5
… coherent with L1Menu_Collisions2022_v0_1_5" This reverts commit bc2cf48.
…t with the L1 menu for Run 3
|
A new Pull Request was created by @elfontan (Elisa Fontanesi) for branch master. @smuzaffar, @epalencia, @iarspider, @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks. |
…t with the L1 menu for Run 3: added a column of 1
|
Pull request #8 was updated. |
…t with the L1 menu for Run 3: moved PS of latest added seeds to 0 as default
|
Pull request #8 was updated. |
…t with the L1 menu for Run 3 (v6)
|
Pull request #8 was updated. |
|
The PR has been updated including a set of files compatible with an updated version of the L1 menu: L1Menu_Collisions2022_v0_1_6. |
|
Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a8e19/22929/summary.html Comparison SummarySummary:
|
|
+l1 |
|
@elfontan these are all new data files. Is there any cms-sw/cmssw pull request which uses these files? |
|
Dear @smuzaffar, |
|
thanks @elfontan but looks like non of the PR tests are actually using the new files otherwise PR tests for httpshttps://github.com/cms-sw/cmssw/pull/37138 should have failed. Are there any |
|
Dear @smuzaffar, We would like to have these files updated just for clarity and coherence with what we are going to use (in terms of menu and prescales) as default for Run 3. (Most likely these files will be updated again by the end of the month, so we can also consider to postpone this point - but having it clarified by the preparation of CMSSW_12_3_0). Cheers, |
|
+externals sounds good @elfontan . I am merging this now and these new files should be available in next CMSSW_12_4_X IB . If you need to get these files back ported to 12.3.X then please open a github issue for cms-sw/cmssw repository |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
Hello @smuzaffar, Cheers, |
A full set of xml files for the L1 emulation of prescales and masks coherent with the updated L1 menu for Run 3 has been created. The current version of the updated L1 Menu can be found in [1]: L1Menu_Collisions2022_v0_1_5.
In the context of the trigger studies for the preparation of the Run 3 menu (L1+HLT), we recently faced an issue related to the emulation of the L1 prescales. Two different issues were found out:
Once that these new files are available here, a PR to update the PrescalesVetosFract_cff.py file will be prepared.
[1]
https://github.com/cms-l1-dpg/L1MenuRun3/tree/master/preliminary/L1Menu_Collisions2022_v0_1_5