New DQM stream file for new RawPrime by silviodonato · Pull Request #13 · cms-data/DQM-Integration

silviodonato · 2025-09-29T09:31:55Z

New DQM stream file for new RawPrime necessary to get the test working with cms-sw/cmssw#49013

add ini

cmsbuild · 2025-09-29T09:32:24Z

A new Pull Request was created by @silviodonato for branch main.

@akritkbehera, @cmsbuild, @ctarricone, @gabrielmscampos, @iarspider, @nothingface0, @rseidita, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2025-09-29T09:32:24Z

cms-bot internal usage

gabrielmscampos · 2025-09-29T09:41:28Z

test parameters:

addpkg = DQM/Integration

gabrielmscampos · 2025-09-29T09:42:29Z

@cmsbuild, please test

cmsbuild · 2025-09-29T12:03:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cd41f/48334/summary.html
COMMIT: 38ac8c3
CMSSW: CMSSW_16_0_X_2025-09-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/DQM-Integration/13/48334/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
2024.0050001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially added 13 lines to the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3861349
DQMHistoTests: Total failures: 26
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3861303
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

gabrielmscampos · 2025-09-29T12:24:58Z

Hi @mmusich, sorry to bother you. I triggered the tests based on your last review of #12. Should we also trigger a new test here, asking the bot to include cms-sw/cmssw#49013 (after it gets merged)?

That PR doesn’t touch DQM, so, to my understanding, it shouldn’t affect the integration tests in this scope with the newly added data. If we don’t need to wait for cms-sw/cmssw#49013 and trigger the tests again, I can sign it right away.

mmusich · 2025-09-29T12:27:56Z

@silviodonato @gabrielmscampos despite the +1 from the bot there is a problem here.
Seems like the test didn't even process any data link.

29-Sep-2025 12:21:03 CEST  Found and loaded json file: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_0_X_2025-09-28-2300/external/el8_amd64_gcc12/data/DQM/Integration/data/run362321/run362321_ls0231_streamHIDQM_pid1736357.jsn
29-Sep-2025 12:21:03 CEST  Timeout reached, skipping lumisection(s) 1 .. 230, nextLumiNumber_ is now 231
29-Sep-2025 12:21:03 CEST  Streamer state changed: 0->1
29-Sep-2025 12:21:03 CEST  Waiting for the first lumi in order to initialize.
29-Sep-2025 12:21:03 CEST  Data file (specified in json) is missing:/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_0_X_2025-09-28-2300/external/el8_amd64_gcc12/data/DQM/Integration/data/run362321/0
29-Sep-2025 12:21:03 CEST  Streamer state changed: 1->2
29-Sep-2025 12:21:03 CEST  End of run reached before DQMStreamerReader was initialised.

run362321/run362321_ls0231_streamHIDQM_pid1736357.jsn

Co-authored-by: Marco Musich <[email protected]>

cmsbuild · 2025-09-29T12:35:24Z

Pull request #13 was updated.

mmusich · 2025-09-29T12:36:31Z

@cmsbuild, please test

cmsbuild · 2025-09-29T14:47:34Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cd41f/48340/summary.html
COMMIT: adb50b4
CMSSW: CMSSW_16_0_X_2025-09-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/DQM-Integration/13/48340/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMOnlineClient-sistrip_approx_dqm_sourceclient had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
2024.0050001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially added 14 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3861349
DQMHistoTests: Total failures: 20
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3861309
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

mmusich · 2025-09-29T14:49:56Z

Should we also trigger a new test here, asking the bot to include cms-sw/cmssw#49013 (after it gets merged)?

@gabrielmscampos, so to answer your question, #13 (comment) shows that this PR is inextricably tangled with the cmssw one, cms-sw/cmssw#49013 and they should be tested (and merged) together.

mmusich · 2025-09-29T14:50:26Z

test parameters:

pull_request = New version of RawPrime (SiStripApproximateCluster) cms-sw/cmssw#49013

mmusich · 2025-09-29T14:50:37Z

@cmsbuild, please test

cmsbuild · 2025-09-29T17:30:50Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cd41f/48352/summary.html
COMMIT: adb50b4
CMSSW: CMSSW_16_0_X_2025-09-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/DQM-Integration/13/48352/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@mmusich PrimaryVertexResolution: add protection against missing track references in input vertex cms-sw/cmssw#49014

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cd41f/48352/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cd41f/48352/git-merge-result

Comparison Summary

Summary:

You potentially added 20 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3922620
DQMHistoTests: Total failures: 38
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3922562
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

gabrielmscampos · 2025-10-01T07:44:25Z

Hi @mmusich, since #49013 was closed, I guess we need to trigger the tests here with #49015. From the bot commands page I didn't understand how to remove #49013 from test_parameters. Specifying a new PR would overwrite the previous declaration?

mmusich · 2025-10-01T07:46:09Z

@gabrielmscampos
since cms-sw/cmssw#49013 was closed (for reasons I don't know ) this PR is not needed anymore.

smuzaffar · 2025-12-02T09:57:28Z

I am closing this PR, we can re-open it if needed

file for new RawPrime

38ac8c3

add ini

cmsbuild added orp-pending externals-pending pending-signatures dqm-pending tests-pending labels Sep 29, 2025

silviodonato mentioned this pull request Sep 29, 2025

New version of RawPrime (SiStripApproximateCluster) cms-sw/cmssw#49013

Closed

cmsbuild added tests-started and removed tests-pending labels Sep 29, 2025

cmsbuild added tests-approved and removed tests-started labels Sep 29, 2025

mmusich reviewed Sep 29, 2025

View reviewed changes

run362321/run362321_ls0231_streamHIDQM_pid1736357.jsn Outdated Show resolved Hide resolved

Update run362321/run362321_ls0231_streamHIDQM_pid1736357.jsn

adb50b4

Co-authored-by: Marco Musich <[email protected]>

cmsbuild added tests-pending and removed tests-approved labels Sep 29, 2025

cmsbuild added tests-started and removed tests-pending labels Sep 29, 2025

cmsbuild added tests-rejected and removed tests-started labels Sep 29, 2025

cmsbuild added requires-external tests-started and removed tests-rejected labels Sep 29, 2025

cmsbuild added tests-approved and removed tests-started labels Sep 29, 2025

smuzaffar closed this Dec 2, 2025

Conversation

silviodonato commented Sep 29, 2025

Uh oh!

cmsbuild commented Sep 29, 2025

Uh oh!

cmsbuild commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabrielmscampos commented Sep 29, 2025

Uh oh!

gabrielmscampos commented Sep 29, 2025

Uh oh!

cmsbuild commented Sep 29, 2025

Comparison Summary

Uh oh!

gabrielmscampos commented Sep 29, 2025

Uh oh!

mmusich commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cmsbuild commented Sep 29, 2025

Uh oh!

mmusich commented Sep 29, 2025

Uh oh!

cmsbuild commented Sep 29, 2025

Unit Tests

Comparison Summary

Uh oh!

mmusich commented Sep 29, 2025

Uh oh!

mmusich commented Sep 29, 2025

Uh oh!

mmusich commented Sep 29, 2025

Uh oh!

cmsbuild commented Sep 29, 2025

Comparison Summary

Uh oh!

gabrielmscampos commented Oct 1, 2025

Uh oh!

mmusich commented Oct 1, 2025

Uh oh!

smuzaffar commented Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cmsbuild commented Sep 29, 2025 •

edited

Loading

mmusich commented Sep 29, 2025 •

edited

Loading