Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 24, 2025

Needed by cms-sw/cmssw#47430, due to the class layout change for GlobalObjectMapRecord due to cms-sw/cmssw#47030.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for branch main.

@antoniovagnerini, @cmsbuild, @iarspider, @rseidita, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Feb 24, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16e413/44616/summary.html
COMMIT: f074d53
CMSSW: CMSSW_15_1_X_2025-02-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/DQM-Integration/10/44616/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16e413/44616/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16e413/44616/git-merge-result

Comparison Summary

Summary:

  • You potentially added 14 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920300
  • DQMHistoTests: Total failures: 49
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3920231
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela: This PR was tested with cms-sw/cmssw#47430, please check if they should be merged together

@smuzaffar
Copy link
Contributor

+externals

@mandrenguyen
Copy link

+1
dqm signature is assumed, as the PR that depends on this change (cms-sw/cmssw#47430) is signed.

@mmusich
Copy link
Contributor Author

mmusich commented Feb 25, 2025

@antoniovagnerini can you please sign this one as well?

@smuzaffar
Copy link
Contributor

smuzaffar commented Feb 25, 2025

merging it as cms-sw/cmssw#47430 has been merged (which requires this PR)

@smuzaffar smuzaffar merged commit 33ecc66 into cms-data:main Feb 25, 2025
9 checks passed
@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next main IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants