Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 2, 2022

Title says it all, moved from cmssw/CalibTracker/SiStripQuality.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2022

A new Pull Request was created by @mmusich (Marco Musich) for branch main.

@smuzaffar, @malbouis, @iarspider, @cmsbuild, @ggovi, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 2, 2022

needed for cms-sw/cmssw#37120.

@mmusich
Copy link
Contributor Author

mmusich commented Mar 2, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a20b9e/22782/summary.html
COMMIT: 916d62f
CMSSW: CMSSW_12_3_X_2022-03-02-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/CondTools-SiStrip/2/22782/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 26 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3987333
  • DQMHistoTests: Total failures: 152
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 3987153
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -6538.53 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -1091.170 KiB HLT/BPH
  • DQMHistoSizes: changed ( 11634.0,... ): 1.415 KiB HLT/Filters
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 7 / 48 workflows

@tvami
Copy link

tvami commented Mar 2, 2022

+1

@qliphy
Copy link
Contributor

qliphy commented Mar 4, 2022

+1

@qliphy
Copy link
Contributor

qliphy commented Mar 4, 2022

merge

@cmsbuild cmsbuild merged commit beb59bd into cms-data:main Mar 4, 2022
@mmusich mmusich deleted the patch1 branch March 4, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants