Skip to content

Run the likelihood scan for RooMultiPdf in the cvmfs workflow #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anigamova wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Run the likelihood scan for RooMultiPdf in the cvmfs workflow #1111

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
90afd19
run likelihood scans for RooMultiPdf, upload the .pdf
Aug 11, 2025
78935bb
update upload-artifact to v4
Aug 11, 2025
ffb4319
fix a typo
Aug 11, 2025
40c2d62
move the .pdf file
anigamova Aug 11, 2025
30a601a
fix wrong option
anigamova Aug 11, 2025
f2bd4ac
set the path for the artifacts
anigamova Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/cvmfs-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ jobs:
shell: bash
options: ${{env.docker_opt_rw}}
run: |
mkdir -p ${{ github.workspace }}/artifacts
cd /home/cmsusr/
source /cvmfs/cms.cern.ch/cmsset_default.sh
scram project ${CMSSW_VERSION}
Expand Down Expand Up @@ -162,6 +163,15 @@ jobs:
ulimit -s unlimited
text2workspace.py HiggsAnalysis/CombinedLimit/data/ci/datacard_RooMultiPdf.txt.gz -o ws_RooMultiPdf.root
combine -M MultiDimFit -m 125.38 --setParameters pdf_index_ggh=2 --freezeParameters MH --cminDefaultMinimizerStrategy 0 --X-rtd FAST_VERTICAL_MORPH --X-rtd MINIMIZER_freezeDisassociatedParams --X-rtd MINIMIZER_multiMin_maskChannels=2 --algo singles ws_RooMultiPdf.root
combine -M MultiDimFit -m 125.38 -n RooMultiPdfGrid --freezeParameters MH --cminDefaultMinimizerStrategy 0 --X-rtd FAST_VERTICAL_MORPH --X-rtd MINIMIZER_freezeDisassociatedParams --X-rtd MINIMIZER_multiMin_maskChannels=2 --algo grid ws_RooMultiPdf.root --setParameterRanges r=-1,2 --points 80 -P r
plot1DScan.py higgsCombineRooMultiPdfGrid.MultiDimFit.mH125.38.root -o scan_RooMultiPdf
cp scan_RooMultiPdf.pdf ${{ github.workspace }}/artifacts/.

Comment on lines +166 to +169
Copy link
Contributor

@coderabbitai coderabbitai bot Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

⚠️ Potential issue

Mount the workspace in the RooMultiPdf container; current cp to ${{ github.workspace }} will fail

The container for this step doesn’t mount the runner workspace, so copying to ${{ github.workspace }}/artifacts will fail. Also, add -P r to plot1DScan for explicit POI and remove trailing spaces flagged by YAMLlint.

Apply this diff within the run block to create the artifacts dir on the mounted path, make the plot deterministic wrt POI, and export the PDF:

-            combine -M MultiDimFit -m 125.38 -n RooMultiPdfGrid --freezeParameters MH --cminDefaultMinimizerStrategy 0 --X-rtd FAST_VERTICAL_MORPH --X-rtd MINIMIZER_freezeDisassociatedParams --X-rtd MINIMIZER_multiMin_maskChannels=2 --algo grid ws_RooMultiPdf.root --setParameterRanges r=-1,2 --points 80 -P r
-            plot1DScan.py higgsCombineRooMultiPdfGrid.MultiDimFit.mH125.38.root -o scan_RooMultiPdf 
-            cp scan_RooMultiPdf.pdf ${{ github.workspace }}/artifacts/.
-            
+            combine -M MultiDimFit -m 125.38 -n RooMultiPdfGrid --freezeParameters MH --cminDefaultMinimizerStrategy 0 --X-rtd FAST_VERTICAL_MORPH --X-rtd MINIMIZER_freezeDisassociatedParams --X-rtd MINIMIZER_multiMin_maskChannels=2 --algo grid ws_RooMultiPdf.root --setParameterRanges r=-1,2 --points 80 -P r
+            plot1DScan.py higgsCombineRooMultiPdfGrid.MultiDimFit.mH125.38.root -o scan_RooMultiPdf -P r
+            mkdir -p /work/artifacts
+            cp scan_RooMultiPdf.pdf /work/artifacts/

Additionally, update the container options for this step to mount the runner workspace (outside this hunk):

# In the RooMultiPdf step
options: ${{ env.docker_opt_ro }} -v ${{ github.workspace }}:/work

This resolves the file export and the YAMLlint trailing-space errors on Lines 167 and 169.

🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 167-167: trailing spaces

(trailing-spaces)

[error] 169-169: trailing spaces

(trailing-spaces)

🤖 Prompt for AI Agents 
In .github/workflows/cvmfs-ci.yml around lines 166-169, the RooMultiPdf
container step currently tries to cp to ${{ github.workspace }} but the runner
workspace isn't mounted and YAMLlint flags trailing spaces; update the run block
to create and use an artifacts directory on the mounted path (e.g.,
/work/artifacts), add the explicit POI flag -P r to plot1DScan, and remove
trailing spaces on the listed lines; also update the container options for that
RooMultiPdf step (outside this hunk) to mount the workspace by adding options:
${{ env.docker_opt_ro }} -v ${{ github.workspace }}:/work so the cp to
/work/artifacts succeeds.

- name: Upload scan_RooMultiPdf.pdf
uses: actions/upload-artifact@v4
with:
name: Scan for RooMultiPdf
path: ${{ github.workspace }}/artifacts/scan_RooMultiPdf.pdf

- uses: rhaschke/docker-run-action@v5
name: RooParametricHist
Expand Down
Loading