Cleanup of obsolete extended tracking code #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aehart
force-pushed
the
displaced_cleanup
branch
from
d50a7f6 to
8b60d2e
Compare
tomalin
approved these changes
Jan 13, 2026
Collaborator
tomalin
left a comment
tomalin
left a comment
There was a problem hiding this comment.
This looks OK to me, but I suggest @sarafiorendi checks it too before we merged it.
Author
|
N.B.: I just found two orphan method declarations in Sector.h that no longer have a corresponding definition in Sector.cc, so I removed these in c74d45b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
While preparing cms-sw#49779, I realized there are still a couple artifacts from before the TrackletEngineDisplaced, TripletEngine, and TrackletCalculatorDisplaced were combined into the TrackletProcessorDisplaced. So this PR:
PR validation:
Since the current wiring makes no reference to the TrackletCalculatorDisplaced or the StubTripletsMemory there is no change to the behavior of the extended tracking emulation, and the code compiles and runs as before.