forked from cms-sw/cmssw
-
Notifications
You must be signed in to change notification settings - Fork 6
Add helix fit covariance matrix to HYBRID output #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tomalin
wants to merge
21
commits into
L1TK-dev-15_1_0_pre4
Choose a base branch
from
ianAddCovMatNew
base: L1TK-dev-15_1_0_pre4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+534
−590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Thanks to this PR, the covariance matrix obtained from the HYBRID KF fit is now stored in the TTTrack object, and a couple of histograms "resOverSigma*z0"plotting z0 resolution divided by the uncertainty in the z0 taken from this matrix have been added to L1TrackNtuplePlot.C .
In addition, the TTTrack object has been slightly tidied up. This clean up preserves backwards compatibility, so it should still be possible to read old datasets, but a couple of changes are needed to L1 trigger code.
IMPORTANT: When a PR is made to central CMSSW, any L1 trigger code that still uses the original 6 bit "MVAOther" type names will need modifying in the PR too, to instead use the two 3 bit fields.
PR validation:
No change in tracking performance.