Skip to content

Conversation

@A-A-Abdelhamid
Copy link

I noticed that in seedWiring.json seeding layer D1D2L2 projects into L3 and D5, which do not exist among the allowed projections in Settings.h

@tomalin , I know Andrew might be already working on cleaning seedWiring.json but I wanted to point this out while we are at it.

@tomalin
Copy link
Collaborator

tomalin commented Jul 22, 2025

PR are only allowed from branches in the cms-L1TK fork. This is why CI does not run.
@aehart since you are making a TrackFindingTracklet/data PR to central CMSSW, what do you want to do with this additional correction?

@aehart
Copy link

aehart commented Jul 23, 2025

PR are only allowed from branches in the cms-L1TK fork. This is why CI does not run. @aehart since you are making a TrackFindingTracklet/data PR to central CMSSW, what do you want to do with this additional correction?

I think it makes sense to add this update to cms-data/L1Trigger-TrackFindingTracklet#8, so I will do that today. Although, apparently, nobody is reviewing/merging the PRs in that repo…

@tomalin
Copy link
Collaborator

tomalin commented Jul 29, 2025

@aehart & @A-A-Abdelhamid I propose to merge this PR. Although Andrew's PR cms-data/L1Trigger-TrackFindingTracklet#8 will fix the json in central CMSSW, we need the same fix in cms-L1TK, and this PR of Alaa will do that. I've checked that both jsons are identical. However, Alaa needs to stop using his personal branch for this PR. Otherwise CI will not run and I can't merge.

tomalin

This comment was marked as outdated.

@tomalin tomalin dismissed their stale review July 29, 2025 12:47

Realize PR is still using a personal branch.

@A-A-Abdelhamid
Copy link
Author

Hi Ian @tomalin , I do not have the required access to create a branch on the cms-L1TK repo, this is why I have been using A-A-Abdelhamid:L1TK-dev-15_1_0_pre4 branch

@tomalin
Copy link
Collaborator

tomalin commented Oct 8, 2025

@A-A-Abdelhamid I've just given you permission to create branches in cms-L1TK. Check if you've received an Email invitation. Can you move this PR to such a branch, and make a PR from there, so CI works please?

@A-A-Abdelhamid
Copy link
Author

@A-A-Abdelhamid I've just given you permission to create branches in cms-L1TK. Check if you've received an Email invitation. Can you move this PR to such a branch, and make a PR from there, so CI works please?

@tomalin Thanks! I created a new PR#338 from the cms-L1TK repo, closing this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants