archive config - rewrite if prefix is invalid - #73
Open
DamianZaremba wants to merge 1 commit into
Open
Conversation
Trivy Security Scancnb/lifecycle/launcher
layers/sbom/launch/buildpacksio_lifecycle/launcher/sbom.cdx.json
layers/sbom/launch/buildpacksio_lifecycle/launcher/sbom.spdx.json
|
DamianZaremba
force-pushed
the
feature/check-archive-prefix-at-config-parse
branch
4 times, most recently
from
August 31, 2026 15:13
a98bdbb to
30b60bc
Compare
DamianZaremba
force-pushed
the
feature/rewrite-broken-configs
branch
from
August 31, 2026 15:14
009b25e to
32c8c71
Compare
DamianZaremba
force-pushed
the
feature/check-archive-prefix-at-config-parse
branch
from
August 31, 2026 15:15
30b60bc to
606b575
Compare
DamianZaremba
force-pushed
the
feature/rewrite-broken-configs
branch
from
August 31, 2026 15:15
32c8c71 to
a0c7959
Compare
DamianZaremba
force-pushed
the
feature/check-archive-prefix-at-config-parse
branch
from
August 31, 2026 15:22
606b575 to
c463baa
Compare
DamianZaremba
force-pushed
the
feature/rewrite-broken-configs
branch
2 times, most recently
from
August 31, 2026 15:25
0d83eae to
f858145
Compare
DamianZaremba
force-pushed
the
feature/check-archive-prefix-at-config-parse
branch
from
August 31, 2026 16:06
c463baa to
0712369
Compare
DamianZaremba
force-pushed
the
feature/rewrite-broken-configs
branch
2 times, most recently
from
August 31, 2026 16:11
0a65bdf to
423109d
Compare
DamianZaremba
force-pushed
the
feature/check-archive-prefix-at-config-parse
branch
from
August 31, 2026 16:14
0712369 to
1c3359a
Compare
DamianZaremba
force-pushed
the
feature/rewrite-broken-configs
branch
from
August 31, 2026 16:14
423109d to
bf1e66f
Compare
DamianZaremba
force-pushed
the
feature/check-archive-prefix-at-config-parse
branch
from
August 31, 2026 16:16
1c3359a to
f4dfdd9
Compare
DamianZaremba
force-pushed
the
feature/rewrite-broken-configs
branch
from
August 31, 2026 16:16
bf1e66f to
8730052
Compare
DamianZaremba
force-pushed
the
feature/check-archive-prefix-at-config-parse
branch
from
August 31, 2026 16:39
f4dfdd9 to
5f5afd2
Compare
DamianZaremba
force-pushed
the
feature/rewrite-broken-configs
branch
2 times, most recently
from
August 31, 2026 17:30
0771e88 to
5fe2310
Compare
An error occurred while trying to automatically change base from
feature/check-archive-prefix-at-config-parse
to
feature/refactor-archive-config
August 31, 2026 17:40
DamianZaremba
force-pushed
the
feature/rewrite-broken-configs
branch
from
September 1, 2026 13:02
5fe2310 to
bbfd66b
Compare
Currently we log an error on every run with no feedback to the user. Re-use the logic we have for dealing with `once` to explicitly re-write the config to the calculated value. This will fix some live instances (fallback value) and make archiving behaviour more obuvious when the prefix is wrong. In the worst case it will annoy the user into contacting us where we can explain what is happening. Note: This will update all configs regardless of if we need to archive
DamianZaremba
force-pushed
the
feature/rewrite-broken-configs
branch
from
September 1, 2026 13:03
bbfd66b to
a9cbf31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we log an error on every run with no feedback to the user.
Re-use the logic we have for dealing with
onceto explicitly re-writethe config to the calculated value.
This will fix some live instances (fallback value) and make archiving
behaviour more obuvious when the prefix is wrong.
In the worst case it will annoy the user into contacting us where we can
explain what is happening.
Note: This will update all configs regardless of if we need to archive