Update archive key handling - #70
Merged
Merged
Conversation
DamianZaremba
commented
Aug 31, 2026
Member
- bot config - add archive key
- archive prefix key - change hashing algo
Trivy Security Scancnb/lifecycle/launcher
layers/sbom/launch/buildpacksio_lifecycle/launcher/sbom.cdx.json
layers/sbom/launch/buildpacksio_lifecycle/launcher/sbom.spdx.json
|
DamianZaremba
force-pushed
the
feature/update-archive-key-handling
branch
from
August 31, 2026 14:39
e240518 to
42ee74d
Compare
DamianZaremba
force-pushed
the
feature/update-archive-key-handling
branch
from
August 31, 2026 16:05
0d5f263 to
b984f68
Compare
Currently this is tied to the password meaning anytime the password is rotated the archive keys break, now that we are using bot passwords this is potentially more often. Split the usage so the archive key/secret is seperate; it is also not super secure due to the hashing in use.
We rotated the password a while back, so essentially broke all the existing archive keys. Update the hashing algo to a more secure variant as you could in principle brute force the password from a published key, since the inputs are known (public source code).
DamianZaremba
force-pushed
the
feature/update-archive-key-handling
branch
from
August 31, 2026 16:14
b984f68 to
c9865e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.