Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move-robot-ip-address-configuration-to-ros-launch-file-in-kinova-driver #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Leuchak
Copy link
Member

@Leuchak Leuchak commented May 17, 2023

This patch add a new parameter, "kinovaControllerIpAddress", to specify the IP address of the Kinova controller.

This patch was originally part of #37

@Leuchak Leuchak requested review from GLDuval and saxtot May 17, 2023 23:54
@Leuchak Leuchak self-assigned this May 17, 2023
saxtot
saxtot previously approved these changes May 18, 2023
Copy link
Contributor

@saxtot saxtot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice catch for small improvements of the multiple PRs. If you want faster or more thorough reviews in the future, just hit up Gab or me and we'll add more people.

@GLDuval
Copy link
Contributor

GLDuval commented May 24, 2023

I'll approve once we have confirmation that these PRs have been tested

@Leuchak Leuchak force-pushed the move-robot-ip-address-configuration-to-ros-launch-file-in-kinova-driver branch from ca6d4e2 to 5f1b9f1 Compare June 12, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants