customizable toolbars #3259
customizable toolbars #3259
Conversation
|
Can you make a test build? Since the reserved buttons are in the middle of the image, we can't use the image width as an indicator of how many buttons are valid. But perhaps that info could be passed through filename/foldername of an external toolbar. Like "button_bc15.svg" where bc15 means button count 15. |
|
Test build: For valid buttons, my plan was to check for any button data. The region should be left transparent if nothing is designed for that button. |
|
https://mega.nz/file/0RAlkCjS#hkT7-CnU8B4n3f3lXcrNmCXbzgAY6zNPUzaRizlAh58 Updated test build. |
|
In light theme, the active buttons are light gray and disabled buttons dark. Should be swapped. The customize toolbar dialog could probably be moved to a new settings page. Where top half of page is used for the button selection/order. And bottom half for button specific options such as assigning commands to future generic buttons. Current toolbar buttons as the left list and available as right side list? I think that would look a bit more intuitive. Maybe hide the buttons in the list that have a fixed position? (play/pause/stop/mute/separator) Reset button does not work properly yet? As a test I moved the next button to after previous. |
Fixed. It currently uses the same for light and classic, but we could add a third row. |
The dialog it pops up is actually a classic win32 toolbar customization dialog. It probably wouldn't be too hard to reproduce the behavior of it. It shares some behavior with the drag and drop.
Yes that would be helpful. Have to design the whole thing from scratch to do it.
It doesn't appear to work, no. |
|
This has an options page now that allows customizing of the toolbar. It's working pretty well. I did notice one quirk where deleting all buttons will require a reset to add back. I'll fix it soon. |
…arbitrary tb sizes
|
I will check it out very soon |
|
The new toolbar settings page works good. Minor nits: |
|
Made some improvements. The arrows are SVG but maybe something isn't getting smoothed properly. |
Toolbar refers only to the buttons, mute button, and volume control. The seekbar is a separate topic, so please open a different issue to discuss. |
This implements toolbars that can have dynamic elements between the first three "static" toolbar elements, and the volume button at the end.
The SVG is based off my old idea of 4 rows active/inactive/active dark/inactive dark (I forget the exact order). However, the svg is designed to support up to 32 buttons eventually, and is sized accordingly.
The customization works by using the CToolbar drag and drop. It's pretty basic, but you can drag a button off the toolbar to delete it, and drag it left and right to drop it elsewhere. I need to see about the newer (mfc) toolbar capabilities, but given that it always used CToolbar, I thought this would be simplest.
The save and load of the toolbar sequence is implemented.
Adding buttons back to the toolbar can currently only be done through the double click customize dialog. That dialog is not themed and also allows adding separators back (we don't want this). If that can't be fixed we can have an simple dialog to adjust the toolbar.
See what you think. This does not merge due to being designed prior to recent toolbar changes.