Conversation
Fix two P1 tool/runtime robustness gaps and record the related OpenSpec lifecycle updates. Code changes: - default edit_line line_number to 1 when omitted so schema/default behavior matches runtime execution. - harden MCP timeout_seconds coercion: invalid, boolean, or non-positive values now fall back to 30 instead of raising conversion errors. - add regression tests for both behaviors in v4 file tools and MCP provider coverage. OpenSpec changes: - archive fix-tool-capability-listing-contract and refactor-skill-store-builder into changes/archive/2026-02-10-*/. - apply archived spec updates to interface-layer, component-management, and configuration-management. - add new change proposal fix-p1-tool-input-defaults with proposal/tasks/spec deltas. Validation: - .venv/bin/pytest tests/unit/test_v4_file_tools.py tests/unit/test_mcp_tool_provider.py tests/unit/test_tool_manager.py tests/unit/test_tool_gateway.py -q - openspec validate --specs --strict - openspec validate --changes --strict
Prevent explicit null line_number values from being treated as schema defaults in edit_line. The tool now defaults to line 1 only when the field is omitted, while explicit null remains INVALID_LINE, avoiding unintended deletes on malformed input. Harden MCP timeout parsing by catching OverflowError in addition to TypeError/ValueError so non-finite values (for example float infinity) safely fall back to 30 instead of crashing capability registration. Add regression coverage for both paths in test_v4_file_tools and test_mcp_tool_provider to enforce the contract around null line numbers and defensive timeout metadata handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope (One PR One Thing)
Changed Files (required)
List all touched files and why each file changed.
If this PR is a large diff (>300 changed lines), explain why split PRs are not possible and provide a split follow-up plan.
Acceptance Criteria
Test Evidence (required)
.........If this PR changes high-risk runtime paths (auth/concurrency/execution control), include
risk-matrixevidence.Risk and Rollback
Dependency and Lockfile Changes
requirements.txt/pyproject.toml/package.json): [ ] Yes [ ] No [ ] N/AAgent Rules Checklist (required)
Reference:
docs/agent_rules.mdskip/only/excludeusage is explained and reviewed