-
Notifications
You must be signed in to change notification settings - Fork 2
Close governance traceability tasks and finish T0-4/T0-5 hardening #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
719442c
288f902
b83bdc9
af2f06b
0095b35
a709b7d
ed550e8
06330ef
e2a2475
df55503
e2f7a8d
9ff1dc7
17d0869
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| """Supported default checkpoint implementations and contributors.""" | ||
|
|
||
| from dare_framework.checkpoint._internal.contributors.session_contributor import ( | ||
| SessionContextContributor, | ||
| SessionStateContributor, | ||
| ) | ||
| from dare_framework.checkpoint._internal.contributors.stm_contributor import StmContributor | ||
| from dare_framework.checkpoint._internal.contributors.workspace_git_contributor import ( | ||
| WorkspaceGitContributor, | ||
| ) | ||
| from dare_framework.checkpoint._internal.memory_store import MemoryCheckpointStore | ||
| from dare_framework.checkpoint._internal.save_restore import DefaultCheckpointSaveRestore | ||
|
|
||
| __all__ = [ | ||
| "MemoryCheckpointStore", | ||
| "DefaultCheckpointSaveRestore", | ||
| "StmContributor", | ||
| "WorkspaceGitContributor", | ||
| "SessionStateContributor", | ||
| "SessionContextContributor", | ||
| ] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| """Supported default embedding implementations.""" | ||
|
|
||
| from dare_framework.embedding._internal.openai_embedding import OpenAIEmbeddingAdapter | ||
|
|
||
| __all__ = ["OpenAIEmbeddingAdapter"] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| """Supported default event-log implementations.""" | ||
|
|
||
| from dare_framework.event._internal.sqlite_event_log import DefaultEventLog, SQLiteEventLog | ||
|
|
||
| __all__ = ["SQLiteEventLog", "DefaultEventLog"] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| """Supported default extension-point implementation.""" | ||
|
|
||
| from dare_framework.hook._internal.hook_extension_point import HookExtensionPoint | ||
|
|
||
| __all__ = ["HookExtensionPoint"] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| """Supported default planner/remediator implementations.""" | ||
|
|
||
| from dare_framework.plan._internal.default_planner import DefaultPlanner | ||
| from dare_framework.plan._internal.default_remediator import DefaultRemediator | ||
|
|
||
| __all__ = ["DefaultPlanner", "DefaultRemediator"] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,17 @@ | ||
| """Security domain facade.""" | ||
|
|
||
| from dare_framework.security._internal.default_security_boundary import DefaultSecurityBoundary | ||
| from dare_framework.security.errors import ( | ||
| SECURITY_APPROVAL_MANAGER_MISSING, | ||
| SECURITY_POLICY_CHECK_FAILED, | ||
| SECURITY_POLICY_DENIED, | ||
| SECURITY_TRUST_DERIVATION_FAILED, | ||
| SecurityBoundaryError, | ||
| ) | ||
| from dare_framework.security.impl import NoOpSecurityBoundary, PolicySecurityBoundary | ||
| from dare_framework.security.impl import ( | ||
| DefaultSecurityBoundary, | ||
| NoOpSecurityBoundary, | ||
| PolicySecurityBoundary, | ||
|
Comment on lines
+10
to
+13
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Importing Useful? React with 👍 / 👎.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in
Added regression coverage in |
||
| ) | ||
| from dare_framework.security.kernel import ISecurityBoundary | ||
| from dare_framework.security.types import PolicyDecision, RiskLevel, SandboxSpec, TrustedInput | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| """Supported default transport channel adapters.""" | ||
|
|
||
| from dare_framework.transport._internal import ( | ||
| DefaultAgentChannel, | ||
| DirectClientChannel, | ||
| StdioClientChannel, | ||
| WebSocketClientChannel, | ||
| ) | ||
|
|
||
| __all__ = [ | ||
| "DefaultAgentChannel", | ||
| "DirectClientChannel", | ||
| "StdioClientChannel", | ||
| "WebSocketClientChannel", | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dare_framework.checkpoint.defaultsnow importsdare_framework.checkpoint._internal..., but this package tree does not exist in the repo, so any use of this new public module (for examplefrom dare_framework.checkpoint.defaults import MemoryCheckpointStore) fails immediately withModuleNotFoundError. This makes the newly added defaults facade unusable at runtime rather than just enforcing a style refactor.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in
df55503.dare_framework.checkpoint.defaultsno longer imports deleteddare_framework.checkpoint._internal.*modules. I replaced it with in-module compatibility implementations for the exported defaults symbols (MemoryCheckpointStore,DefaultCheckpointSaveRestore, and contributors) so facade imports are valid again.Regression coverage added in
tests/unit/test_checkpoint_defaults.py::test_checkpoint_defaults_module_exports_are_importableto prevent reintroducing broken imports.