Codex/todo ledger unify and archive 20260304 - #177
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1058c87e9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - 全量 TODO / Claim / Feature 状态存在漂移（已 merge 或 archived 的 change 仍标记 active/draft）。 | ||
| - 若干 package `__init__.py` 不满足 facade 约束。 | ||
| - 设计已定义但实现未闭环：`ISecurityBoundary` 接入、plan 驱动执行、EventLog 默认实现、Context 检索融合、完整 HITL 语义。 | ||
| - 设计已定义但实现未闭环：plan attempt 隔离（snapshot/rollback）、Context 检索融合、完整 HITL 语义、P0 conformance gate 与治理自动化门禁。 |
There was a problem hiding this comment.
This update still records P0 conformance gate as not closed, but the same commit archives openspec/changes/p0-conformance-gate even though its tasks.md remains largely unchecked (for example items 1.1–4.3 are still [ ]). Archiving an incomplete change removes it from the active change set and makes governance/CI tracking treat unfinished gate work as historical, which can cause required conformance tasks to be skipped in subsequent planning.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed by scope correction: commit 60fc72d (bulk OpenSpec archive) was removed from this PR via history rewrite. This PR no longer archives openspec/changes/p0-conformance-gate; it now only contains TODO governance doc updates (8 files).
| ## Requirements | ||
| ### Requirement: LLM-driven execute loop | ||
| The runtime SHALL invoke the configured `IModelAdapter` during the execute loop, provide the assembled prompt and available tool definitions, and iterate over tool calls until the model returns a final response. | ||
| The runtime SHALL invoke the configured `IModelAdapter` during the execute loop and iterate over tool calls until the model returns a final response. |
There was a problem hiding this comment.
The LLM-driven execute loop requirement no longer requires passing the assembled prompt and available tool definitions into IModelAdapter; it now only says the adapter is invoked and tool calls are iterated. That weakens the normative contract enough that an implementation could technically conform while calling the model without tool schemas/context, which would break deterministic tool-call behavior and make runtime/tool integration expectations ambiguous.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Addressed by the same scope correction: the spec-sync changes that weakened this contract were part of removed commit 60fc72d. Current PR diff no longer modifies openspec/specs/chat-runtime/spec.md.
f1058c8 to
75f0995
Compare
Refreshes TODO governance docs to remove tracking ambiguity and align execution slicing with dependency-driven planning. Key changes: - Archive completed 2026-02-27 design review/reconstructability analysis+todo documents under docs/todos/archive and update all references. - Rework AgentScope execution board to a single numbering style (D* with D*_a/b/c slices), with explicit dependency declarations and staged sequencing. - Rework project_overall mapping to avoid duplicate status tracking between T* and D* and keep AgentScope slices as single source of truth. - Normalize Claim Ledger lifecycle to planned/active/done/deprecated, add owner provenance guidance, and document state transitions in docs/todos/README.md. - Enforce deprecated-row formatting rules (row strike-through except Notes, with scope delimiter adjusted to avoid markdown rendering issues). - Synchronize owner fields in active/history claims with current maintainer identity for this branch context. Rationale: - Clarifies assignment boundaries for parallel delegation and removes conflicting status vocabularies. - Preserves historical traceability while keeping current execution views operable for dispatch.
75f0995 to
f6465ca
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6465ca4cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - `archive/2026-02-27_full_design_review_gap_analysis.md`：全量设计文档评审差异分析（第二轮，已归档）。 | ||
| - `archive/2026-02-27_full_design_review_gap_todo.md`：全量设计文档评审对应 TODO 清单（全部 done，已归档）。 | ||
| - `archive/2026-02-27_design_reconstructability_gap_analysis.md`：可重建性差异分析（P0/P1 闭环，已归档）。 | ||
| - `archive/2026-02-27_design_reconstructability_gap_todo.md`：可重建性治理 TODO 清单（全部 done，已归档）。 |
There was a problem hiding this comment.
Archiving these TODO files under docs/todos/archive/ changes their canonical paths, but the historical change record still points to the pre-move locations (openspec/changes/archive/2026-02-27-close-design-reconstructability-gaps/tasks.md lines 3-4). In this state those evidence links no longer resolve, which breaks traceability when reviewers or governance checks follow the archived OpenSpec references.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 3e3b368. Updated archived OpenSpec evidence links in openspec/changes/archive/2026-02-27-close-design-reconstructability-gaps/tasks.md lines 3-4 to the new canonical paths under docs/todos/archive/....
Verification:
./scripts/ci/check_governance_traceability.sh=> passed./scripts/ci/check_governance_evidence_truth.sh=> passed
Update archived OpenSpec task evidence references after TODO documents were moved under docs/todos/archive/.\n\nChanges:\n- Rewrite two evidence links in openspec/changes/archive/2026-02-27-close-design-reconstructability-gaps/tasks.md from docs/todos/... to docs/todos/archive/...\n\nWhy:\n- Preserve historical traceability for archived change records.\n- Address PR #177 review feedback about broken evidence links.\n\nVerification:\n- ./scripts/ci/check_governance_traceability.sh => passed\n- ./scripts/ci/check_governance_evidence_truth.sh => passed
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
2026-02-27analysis/TODO docs intodocs/todos/archive/and keep historical links resolvable.planned / active / done / deprecated.Scope (One PR One Thing)
Changed Files (required)
Intent / Implementation Gate (required)
n/a (docs-governance refresh executed directly in this PR)mainbefore this implementation started: [x] N/Ahttps://github.com/zts212653/Deterministic-Agent-Runtime-Engine/pull/177Acceptance Criteria
Acceptance Pack (required)
schema/error semantics/retry):none; rationale: docs-only governance updates, no runtime/API contract changednone; rationale: no executable/runtime behavior changed./scripts/ci/check_governance_evidence_truth.sh./scripts/ci/check_governance_traceability.sh./scripts/ci/check_design_doc_drift.shnoneruntime/integration suite skipped because this PR is docs-onlyn/a; rationale: docs-only change./scripts/ci/check_governance_evidence_truth.sh,./scripts/ci/check_governance_traceability.sh,./scripts/ci/check_design_doc_drift.shTest Evidence (required)
./scripts/ci/check_governance_evidence_truth.sh./scripts/ci/check_governance_traceability.sh./scripts/ci/check_design_doc_drift.shci-gate / governance-evidence-truthci-gate / governance-traceabilityci-gate / design-doc-driftRisk and Rollback
f6465cato restore previous docs/claim layout.Structured Review Report (required)
Changed Module Boundaries / Public API
New State
Concurrency / Timeout / Retry
Side Effects and Idempotency
Coverage and Residual Risk
Dependency and Lockfile Changes
requirements.txt/pyproject.toml/package.json): [ ] Yes [ ] No [x] N/AAgent Rules Checklist (required)
Reference:
docs/agent_rules.mdskip/only/excludeusage is explained and reviewed