chore(volo-http): add feature json-utf8-lossy
#530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWhiteWu
previously approved these changes
Nov 11, 2024
Since `sonic-rs` added a new feature `utf8_lossy`, it allows to parse JSON with invalid UTF-8 and UTF-16 characters. When this feature is enabled, invalid characters are replaced with '\uFFFD' (displayed as �) instead of parsing failing due to invalid characters. Signed-off-by: Yu Li <[email protected]>
yukiiiteru
force-pushed
the
chore/sonic-lossy
branch
from
ef06352 to
82e2fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since
sonic-rsadded a new featureutf8_lossy, it allows to parse JSON with invalid UTF-8 and UTF-16 characters.When this feature is enabled, invalid characters are replaced with '\uFFFD' (displayed as �) instead of parsing failing due to invalid characters.
Solution
Add feature
json-utf8-lossyto Volo-HTTP.In addition, this PR also unifies the style of feature names,
default_client, default_serverhave been renamed todefault-client,default-server`.