Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(volo-thrift): client RpcCx didn't clear extension #266

Merged
merged 1 commit into from
Nov 29, 2023
Merged

fix(volo-thrift): client RpcCx didn't clear extension #266

merged 1 commit into from
Nov 29, 2023

Conversation

PureWhiteWu
Copy link
Member

Previously we only clear the rpcinfo and inner part of RpcCx in the client make_cx method, and didn't clear the extension, this pr fixes that.

@PureWhiteWu PureWhiteWu added A-volo-thrift The issue concerns the `volo-thrift` crate. C-bug This is a bug-report. Bug-fix PRs use `C-enhancement` instead. labels Nov 29, 2023
@PureWhiteWu PureWhiteWu self-assigned this Nov 29, 2023
@PureWhiteWu PureWhiteWu requested review from a team as code owners November 29, 2023 04:51
@Millione Millione changed the title fix(lust-thrift): client RpcCx didn't clear extension fix(volo-thrift): client RpcCx didn't clear extension Nov 29, 2023
@PureWhiteWu PureWhiteWu enabled auto-merge (squash) November 29, 2023 04:57
@PureWhiteWu PureWhiteWu merged commit 8f4c347 into cloudwego:main Nov 29, 2023
9 checks passed
@PureWhiteWu PureWhiteWu deleted the fix/client_rpccx_clear branch November 29, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Millione Millione Millione approved these changes

@yukiiiteru yukiiiteru yukiiiteru approved these changes

Assignees

@PureWhiteWu PureWhiteWu

Labels
A-volo-thrift The issue concerns the `volo-thrift` crate. C-bug This is a bug-report. Bug-fix PRs use `C-enhancement` instead.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PureWhiteWu @yukiiiteru @Millione