optimize: check and warn byte in thrift idl #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeyJavaBean
force-pushed
the
optimize/check_byte
branch
from
cf37a53 to
bcdf149
Compare
xiaost
reviewed
Nov 8, 2024
| @@ -145,11 +145,28 @@ func (c *checker) CheckStructLikes(t *parser.Thrift) (warns []string, err error) | |||
| warns = append(warns, fmt.Sprintf("non-positive ID %d of field %q in %q", | |||
| f.ID, f.Name, s.Name)) | |||
| } | |||
| if containByteType(f.Type) { | |||
There was a problem hiding this comment.
单独对list分开一个判断吧来提示 binary，不然说明太长，更没人看
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
check and warn when there're 'byte' in thrift idl
Motivation and Context
'byte' is not recommended to use anymore.
Related Issue