Implement tcp proxy with streaming example #8
+121
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jayantxie
reviewed
Mar 18, 2025
| case <-ctx.Done(): | ||
| return | ||
| default: | ||
| buf, err := reader.ReadBinary(reader.Len()) |
There was a problem hiding this comment.
should add reader.Peek(1) before ReadBinary
There was a problem hiding this comment.
should use reader.Next(reader.Len()) to reduce copy.
jayantxie
reviewed
Mar 18, 2025
| return | ||
| } | ||
|
|
||
| alloc, err := writer.Malloc(len(buf)) |
There was a problem hiding this comment.
should use WriteBinary to reduce copy
jayantxie
reviewed
Mar 18, 2025
|
|
||
| copy(alloc, buf) | ||
|
|
||
| if writer.MallocLen() > 0 { |
There was a problem hiding this comment.
no need to judge MallocLen here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
Check the PR title.
(Optional) Translate the PR title into Chinese.
实现带有流式传输示例的 TCP 代理
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en: Implementing an example for tcp proxy application with nocopy API
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: