fix: oneof type only write/size once #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantxie
approved these changes
Jan 13, 2025
HeyJavaBean
approved these changes
Jan 13, 2025
Contributor
|
actually, I don't know what this change fixed, and it doesn't come with unittest as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it (en: English/zh: Chinese):
en:
zh: pb marshal 默认对于空值是不写入编码的，但是 union 类型存在特例：如果声明了 union 的具体类型默认值，必须要写入这个类型，对端 receive 才能得知 "one of which type"
当前的 fastwrite 没有考虑到这点，直接跳过了带空值的 union 类型，导致接收端无法得知具体是哪个类型
Which issue(s) this PR fixes: