Skip to content

Conversation

@NathanBaulch
Copy link

what

A couple of years ago AWS introduced the option to format S3 access log keys by forward slash instead of hyphen "to speed up analytics and query applications" (quote from AWS Console).

This requires bumping the AWS provider to v5.27. I'm not sure about the wider implications of that.

why

I'd like to access this feature in my IaC scripts.

references

https://registry.terraform.io/providers/hashicorp/aws/5.27.0/docs/resources/s3_bucket_logging#target_object_key_format

@NathanBaulch NathanBaulch requested review from a team as code owners October 28, 2025 00:49
@mergify mergify bot added the triage Needs triage label Oct 28, 2025
Copy link
Member

@joe-niland joe-niland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @NathanBaulch, thanks for this.
Could you please also run make readme to update the docs?

@NathanBaulch
Copy link
Author

Looks like Makefile was replaced with atmos.yaml ~5 months ago. I have no experience with Atmos.

@joe-niland
Copy link
Member

Looks like Makefile was replaced with atmos.yaml ~5 months ago. I have no experience with Atmos.

Ah ok - that's news to me also. I'll look into it.

@joe-niland
Copy link
Member

Looks like Makefile was replaced with atmos.yaml ~5 months ago. I have no experience with Atmos.

So it was just (on a mac):

brew install atmos
atmos readme

https://atmos.tools/install for other platforms.

I've rebuilt the readme.

Please check the linting error: https://github.com/cloudposse/terraform-aws-s3-bucket/actions/runs/18861770411/job/53821423651?pr=282

@NathanBaulch
Copy link
Author

Might be worth documenting the accepted values for object_key_partition_date somewhere - either empty (meaning use the simple format) or EventTime or DeliveryTime (for "partitioned" format). Or even better use a validation. I wasn't sure where to add this given it's a nested field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage Needs triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants