Fix: directory bucket naming should follow [base_bucket]--[availability-zone-id]--x-s3

[sonjali2023]

what

Previous directory bucket name in format [bucket-name]-[availability-zone-id] does not match the expected format in newer versions of terraform docs, should be [base_bucket]--[availability-zone-id]--x-s3. The existing format breaks terraform plan.

• Add new flag s3_directory_bucket_enabled which follows conventions mentioned in fix: renamed create_s3_directory_bucket to conform to cloudposse naming convention #258
• Update the s3_directory_bucket name to be consistent with convention expected by hashicorp [base_bucket]--[availability-zone-id]--x-s3 and aws docs

I made the new changes compatible with old naming (unclear as to if it's necessary) and marked the old variable as deprecated. If user specifies both flags, the new s3_directory_bucket_enabled will take precedence. If users use the old flag, their bucket names are not changed.

why

• old directory bucket names does not match requirements

references

• https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_directory_bucket
• https://docs.aws.amazon.com/AmazonS3/latest/userguide/directory-bucket-naming-rules.html
• Error: AWS S3 directory bucket name fails terraform plan when create_s3_directory_bucket is true #273

[sonjali2023]

/terratest

[guyscher]

any news when this going to be implemented?

[sonjali2023]

any news when this going to be implemented?

great question! I've been hoping someone would come through and review since it's such a straightforward pr, but looks like still hasnt been triaged.