feat: use copylabels from greenhouse propagator#54
Merged
Conversation
…r-runtime v0.23 API changes On-behalf-of: @SAP [email protected] Signed-off-by: Zaggy21 <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Zaggy21 <[email protected]>
…ting shoot annotations On-behalf-of: @SAP [email protected] Signed-off-by: Zaggy21 <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Greenhouse dependency (and aligned Kubernetes/controller-runtime dependencies) and refactors label propagation in the Shoot controller to use the new lifecycle.Propagator.CopyLabels(...) API, along with adapting event recording to the newer k8s.io/client-go/tools/events interface.
Changes:
- Upgrade
github.com/cloudoperators/greenhousetov0.11.1and bump transitive Kubernetes/controller-runtime dependencies. - Migrate event recording from
k8s.io/client-go/tools/recordtok8s.io/client-go/tools/events. - Refactor Shoot→Secret label propagation to use
lifecycle.NewPropagator(&shoot, secret).CopyLabels(...)and update tests accordingly. - Update webhook registration/defaulter signature to match controller-runtime API changes.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
webhook/v1alpha1/careinstruction_webhook.go |
Updates webhook builder usage and defaulter signature for newer controller-runtime. |
controller/shoot/shoot_controller.go |
Migrates EventRecorder API and refactors label propagation to use CopyLabels. |
controller/shoot/shoot_controller_test.go |
Updates tests for new event recorder accessor and changed propagation behavior/annotations. |
controller/careinstruction/careinstruction_controller.go |
Updates event recorder accessor for controller-runtime changes. |
go.mod |
Bumps greenhouse + Kubernetes/controller-runtime dependencies and adds/adjusts replace directives. |
go.sum |
Updates dependency checksums for the upgraded module set. |
.golangci.yaml |
Updates replace allow-list to reflect newly pinned dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…lent k8s module downgrades On-behalf-of: @SAP [email protected] Signed-off-by: Zaggy21 <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Zaggy21 <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Zaggy21 <[email protected]>
On-behalf-of: @SAP [email protected] Signed-off-by: Zaggy21 <[email protected]>
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary