-
Notifications
You must be signed in to change notification settings - Fork 1
feat: watch AuthenticationConfig CM changes #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Zaggy21
wants to merge
15
commits into
main
Choose a base branch
from
feat/watch-authenticationconfig-cm-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
fa4f5d3
feat: label auth CMs on first interaction and reconcile Shoots on Gre…
Zaggy21 e9ede76
add integration tests for auth CM labeling and Greenhouse CM watch-tr…
Zaggy21 6e7444c
add note on auth CM labeling and watch-triggered shoot reconciliation
Zaggy21 8ab78b8
Merge branch 'main' into feat/watch-authenticationconfig-cm-changes
Zaggy21 0372d3f
Merge branch 'main' into feat/watch-authenticationconfig-cm-changes
Zaggy21 463d962
wait for the greenhouse cache before making assertions
Zaggy21 049b9fc
unify the prefix for labels to be shoot-grafter.cloudoperators.dev
Zaggy21 b5c27e8
patch the labels on auth configmap instead of updating
Zaggy21 aeb8e65
fix: skip auth CM relabel when already owned by another CareInstruction
Zaggy21 41e7cf4
fix suggestions
Zaggy21 09e23c9
filter shoots not matching CEL for watch
Zaggy21 95d1352
change the AuthConfigMapLabelKey to shoot-grafter.cloudoperators.dev/…
Zaggy21 02d7a45
restrict watch to specific configmaps, add a timeout to greenhouse ma…
Zaggy21 7b43007
change predicate to fire only when Data in config map changed
Zaggy21 28511b9
fix lint error
Zaggy21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not super convinced that watching resources on two different Clusters is the way to go here.
I would opt to actually watch the CM changes in the CareInstruction controller for separation of concerns.
That would involve:
Looping in @abhijith-darshan for his opinion