Skip to content

fix(ui): fix NaN input in Pagination #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guoda-puidokaite wants to merge 4 commits into
base: main
Choose a base branch
from
+17 −1
Open

fix(ui): fix NaN input in Pagination #1794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
980d81d
fix nan
guoda-puidokaite Jun 24, 2026
ebbf606
changeset and test
guoda-puidokaite Jun 24, 2026
c4c663d
update test
guoda-puidokaite Jun 24, 2026
4675cd1
Merge branch 'main' into guoda-fix-nan
ArtieReus Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eleven-buses-bet.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cloudoperators/juno-ui-components": patch
---

Fix NaN input in Pagination
2 changes: 1 addition & 1 deletion packages/ui-components/src/components/Pagination/Pagination.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ export const Pagination = ({
// Enforce minimum and maximum limits
if (inputValue < 1) {
inputValue = 1
} else if (controlTotalPage !== undefined && inputValue > controlTotalPage) {
} else if (isNaN(inputValue) || (controlTotalPage !== undefined && inputValue > controlTotalPage)) {

@edda edda Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, this won't work if controlTotalPage is undefined. Imo a better way to deal with NaN values is to add it to the inputValue < 1 case instead, because there is always going to be a first page.

inputValue = controlTotalPage
}
}
Expand Down
11 changes: 11 additions & 0 deletions packages/ui-components/src/components/Pagination/Pagination.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,4 +486,15 @@ describe("Pagination", () => {
expect(screen.getByTestId("my-pagination")).toBeInTheDocument()
expect(screen.getByTestId("my-pagination")).toHaveAttribute("data-lolol", "123-456")
})

test("defaults to last page on non-numeric input", () => {
const onInputChangeMock = vi.fn()
render(<Pagination variant="input" totalPages={5} onInputChange={onInputChangeMock} />)

const textInput = screen.getByRole("textbox")
fireEvent.change(textInput, { target: { value: "$" } })

expect(textInput).toHaveValue("5")
expect(onInputChangeMock).toHaveBeenCalledWith(5)
})
})
Loading