chore(deps): upgrade focus-trap-react and node-sass-glob-importer in ui-components#1708
Merged
Merged
Conversation
…porter to 5.3.3 Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
🦋 Changeset detectedLatest commit: 10948c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades devDependencies in @cloudoperators/juno-ui-components to keep focus-management (Modal) and SCSS glob importing (Storybook build) up to date, with corresponding lockfile updates and a patch changeset.
Changes:
- Bumped
focus-trap-reactfrom11.0.6to12.0.2. - Bumped
node-sass-glob-importerfrom3.0.2to5.3.3. - Added a changeset and updated
pnpm-lock.yamlfor the dependency graph changes.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/ui-components/package.json |
Updates the two devDependency versions for ui-components. |
pnpm-lock.yaml |
Regenerates the lockfile to reflect the upgraded dependencies and new transitive deps. |
.changeset/five-jeans-visit.md |
Adds a patch changeset documenting the dependency upgrades. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Resolved pnpm-lock.yaml conflict by regenerating with pnpm install Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
This was
linked to
issues
May 21, 2026
franzheidl
approved these changes
May 21, 2026
franzheidl
left a comment
franzheidl
left a comment
Member
There was a problem hiding this comment.
Tested in several Modals, works for me. 👍
andypf
approved these changes
May 21, 2026
hodanoori
approved these changes
May 21, 2026
hodanoori
pushed a commit
that referenced
this pull request
Jun 11, 2026
…ui-components (#1708) * chore(deps): upgrade focus-trap-react to 12.0.2 and node-sass-glob-importer to 5.3.3 Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com> * chore(ui): added changeset Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com> --------- Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com> Signed-off-by: Hoda Noori <hoda.noori@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
focus-trap-reactfrom 11.0.6 to 12.0.2 andnode-sass-glob-importerfrom 3.0.2 to 5.3.3 in the ui-components package. Both are devDependencies used for development and Storybook builds.Changes Made
focus-trap-reactfrom 11.0.6 to 12.0.2 inpackages/ui-components/package.jsononPostActivate()timing corrected (not used in our codebase)node-sass-glob-importerfrom 3.0.2 to 5.3.3 inpackages/ui-components/package.jsonpnpm-lock.yamlto reflect dependency changesRelated Issues
Screenshots (if applicable)
N/A - No visual changes
Testing Instructions
pnpm installcd packages/ui-components && pnpm build- Verify ui-components builds successfullycd packages/ui-components && pnpm build-storybook- Verify Storybook builds (tests node-sass-glob-importer)pnpm build- Verify all packages and apps build successfullyChecklist
PR Manifesto
Review the PR Manifesto for best practises.