chore(deps): upgrade jsdom from 26.1.0 to 29.1.1#1699
Merged
Conversation
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
🦋 Changeset detectedLatest commit: 16f9485 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades jsdom to 29.1.1 across the monorepo to keep the test/runtime DOM environment current, and adjusts a GridColumn unit test to accommodate jsdom 29’s updated getComputedStyle() defaults.
Changes:
- Bumped
jsdomfrom26.1.0to29.1.1across apps/packages and refreshedpnpm-lock.yaml. - Updated
GridColumn.test.tsxto assert absence of an inlinestyleattribute for the default case (instead of relying on empty computed-style values).
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates lockfile entries to reflect jsdom@29.1.1 and new transitive dependencies. |
| packages/url-state-provider/package.json | Pins jsdom@29.1.1 for the package’s dev/test environment. |
| packages/ui-components/src/components/GridColumn/GridColumn.test.tsx | Adjusts a test expectation to match jsdom 29 computed-style behavior. |
| packages/ui-components/package.json | Pins jsdom@29.1.1 for UI component testing tooling. |
| packages/template/package.json | Pins jsdom@29.1.1 for the package template’s dev/test setup. |
| packages/communicator/package.json | Pins jsdom@29.1.1 for communicator package tests. |
| apps/template/package.json | Pins jsdom@29.1.1 for the template app’s test environment. |
| apps/supernova/package.json | Pins jsdom@29.1.1 for the supernova app’s test environment. |
| apps/heureka/package.json | Pins jsdom@29.1.1 for the heureka app’s test environment. |
| apps/example/package.json | Pins jsdom@29.1.1 for the example app’s test environment. |
| apps/doop/package.json | Pins jsdom@29.1.1 for the doop app’s test environment. |
| apps/carbon/package.json | Pins jsdom@29.1.1 for the carbon app’s test environment. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
taymoor89
approved these changes
May 19, 2026
hodanoori
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades jsdom from version 26.1.0 to 29.1.1 across all packages in the monorepo. This includes a test fix to align with jsdom 29.x's improved
getComputedStyle()behavior, which now correctly returns default CSS values instead of empty strings, matching actual browser behavior.Changes Made
@cloudoperators/juno-ui-components@cloudoperators/juno-package-template@cloudoperators/juno-communicator@cloudoperators/juno-url-state-providerGridColumn.test.tsxto check for absence of inline style attribute instead of checking for empty computed stylevalues
pnpm-lock.yamlto reflect new jsdom version and dependenciesRelated Issues
N/A - Routine dependency upgrade
Screenshots (if applicable)
N/A - No visual changes
Testing Instructions
pnpm ipnpm test- Verify all tests pass (102 test files, 1307 tests)pnpm lint- Verify linting passespnpm typecheck- Verify type checking passespnpm build- Verify build succeedsChecklist
PR Manifesto
Review the PR Manifesto for best practises.