Skip to content

chore(deps): upgrade jsdom from 26.1.0 to 29.1.1#1699

Merged
ArtieReus merged 3 commits into
mainfrom
artie-upgrade-jsdom-29.1.1
May 19, 2026
Merged

chore(deps): upgrade jsdom from 26.1.0 to 29.1.1#1699
ArtieReus merged 3 commits into
mainfrom
artie-upgrade-jsdom-29.1.1

Conversation

@ArtieReus
Copy link
Copy Markdown
Collaborator

@ArtieReus ArtieReus commented May 19, 2026

Summary

Upgrades jsdom from version 26.1.0 to 29.1.1 across all packages in the monorepo. This includes a test fix to align with jsdom 29.x's improved getComputedStyle() behavior, which now correctly returns default CSS values instead of empty strings, matching actual browser behavior.

Changes Made

  • Updated jsdom dependency from 26.1.0 to 29.1.1 in all workspace packages:
    • @cloudoperators/juno-ui-components
    • @cloudoperators/juno-package-template
    • @cloudoperators/juno-communicator
    • @cloudoperators/juno-url-state-provider
    • All apps: carbon, doop, example, heureka, supernova, template
  • Fixed GridColumn.test.tsx to check for absence of inline style attribute instead of checking for empty computed style
    values
  • Updated pnpm-lock.yaml to reflect new jsdom version and dependencies

Related Issues

N/A - Routine dependency upgrade

Screenshots (if applicable)

N/A - No visual changes

Testing Instructions

  1. pnpm i
  2. pnpm test - Verify all tests pass (102 test files, 1307 tests)
  3. pnpm lint - Verify linting passes
  4. pnpm typecheck - Verify type checking passes
  5. pnpm build - Verify build succeeds

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Copilot AI review requested due to automatic review settings May 19, 2026 12:40
@ArtieReus ArtieReus requested review from a team and franzheidl as code owners May 19, 2026 12:40
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2026

🦋 Changeset detected

Latest commit: 16f9485

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@cloudoperators/juno-url-state-provider Patch
@cloudoperators/juno-messages-provider Patch
@cloudoperators/juno-ui-components Patch
@cloudoperators/juno-communicator Patch
@cloudoperators/juno-package-template Patch
@cloudoperators/juno-app-supernova Patch
@cloudoperators/juno-app-template Patch
@cloudoperators/juno-app-example Patch
@cloudoperators/juno-app-heureka Patch
@cloudoperators/juno-app-carbon Patch
@cloudoperators/juno-app-doop Patch
@cloudoperators/juno-app-greenhouse Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-05-19 14:17 UTC

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades jsdom to 29.1.1 across the monorepo to keep the test/runtime DOM environment current, and adjusts a GridColumn unit test to accommodate jsdom 29’s updated getComputedStyle() defaults.

Changes:

  • Bumped jsdom from 26.1.0 to 29.1.1 across apps/packages and refreshed pnpm-lock.yaml.
  • Updated GridColumn.test.tsx to assert absence of an inline style attribute for the default case (instead of relying on empty computed-style values).

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
pnpm-lock.yaml Updates lockfile entries to reflect jsdom@29.1.1 and new transitive dependencies.
packages/url-state-provider/package.json Pins jsdom@29.1.1 for the package’s dev/test environment.
packages/ui-components/src/components/GridColumn/GridColumn.test.tsx Adjusts a test expectation to match jsdom 29 computed-style behavior.
packages/ui-components/package.json Pins jsdom@29.1.1 for UI component testing tooling.
packages/template/package.json Pins jsdom@29.1.1 for the package template’s dev/test setup.
packages/communicator/package.json Pins jsdom@29.1.1 for communicator package tests.
apps/template/package.json Pins jsdom@29.1.1 for the template app’s test environment.
apps/supernova/package.json Pins jsdom@29.1.1 for the supernova app’s test environment.
apps/heureka/package.json Pins jsdom@29.1.1 for the heureka app’s test environment.
apps/example/package.json Pins jsdom@29.1.1 for the example app’s test environment.
apps/doop/package.json Pins jsdom@29.1.1 for the doop app’s test environment.
apps/carbon/package.json Pins jsdom@29.1.1 for the carbon app’s test environment.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Comment thread packages/ui-components/package.json
Comment thread packages/url-state-provider/package.json
Comment thread packages/communicator/package.json
Comment thread packages/template/package.json
Comment thread apps/template/package.json
Comment thread apps/carbon/package.json
Comment thread apps/example/package.json
Comment thread apps/heureka/package.json
ArtieReus added 2 commits May 19, 2026 16:04
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
@ArtieReus ArtieReus merged commit 0e11c6e into main May 19, 2026
25 checks passed
@ArtieReus ArtieReus deleted the artie-upgrade-jsdom-29.1.1 branch May 19, 2026 14:16
@ArtieReus ArtieReus linked an issue May 19, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] (Juno): Upgrade jsdom from v26.x.x to v27.x.x

4 participants