fix(greenhouse): improve ReadinessConditions layout with responsive column widths#1694
Merged
Conversation
…olumn widths Signed-off-by: Arturo Reuschenbach Puncernau <[email protected]>
Signed-off-by: Arturo Reuschenbach Puncernau <[email protected]>
🦋 Changeset detectedLatest commit: 334350c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Greenhouse admin ReadinessConditions details layout to prevent long condition type labels from overlapping their values by introducing responsive label-column sizing and simplifying the card structure.
Changes:
- Added responsive width/overflow/wrapping Tailwind classes for the label column via a shared
gridColumnClassesconstant. - Simplified
ConditionCardlayout by removing an extraStackwrapper and addingmt-4spacing to theGrid. - Added a changeset to publish the Greenhouse app patch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/greenhouse/src/components/admin/common/ReadinessConditions.tsx | Adjusts the expanded condition-card grid layout to avoid label/value overlap using responsive column sizing. |
| .changeset/fruity-schools-stand.md | Declares a patch release for the Greenhouse app reflecting the UI fix. |
Signed-off-by: Arturo Reuschenbach Puncernau <[email protected]>
TilmanHaupt
previously approved these changes
May 15, 2026
MartinS-git
reviewed
May 15, 2026
MartinS-git
approved these changes
May 15, 2026
Co-authored-by: Martin Schulze <[email protected]> Signed-off-by: Arturo Reuschenbach Puncernau <[email protected]>
48c3f28 to
108a949
Compare
TilmanHaupt
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes text overflow issues in the ReadinessConditions component where long condition type names (e.g., "HelmReleaseCreated") were overlapping with their corresponding values.
Changes Made
max-w-xs(320px) on label column to prevent excessive width on very large screenswhitespace-normal sm:whitespace-nowrapmt-4margin to Grid for proper spacing from badgeRelated Issues
Fixes visual layout bug where condition type labels overlapped with their values in admin condition cards.
Screenshots (if applicable)
Before:
Screen.Recording.2026-05-13.at.19.09.25.mov
After:
Screen.Recording.2026-05-13.at.19.08.41.mov
Testing Instructions
pnpm ipnpm dev(or start the greenhouse app)enableDetailsView={true}Checklist
PR Manifesto
Review the PR Manifesto for best practises.