Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/remove-spinner-hardcoded-margin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cloudoperators/juno-ui-components": patch
---

Remove hardcoded `jn:mr-3` margin from Spinner component. The margin was applied globally, causing layout issues when Spinner is used inside components like Button that manage their own spacing. Callers that relied on the built-in margin have been updated to add the margin explicitly.
2 changes: 1 addition & 1 deletion apps/doop/src/components/shared/HintLoading.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { Stack, Spinner } from "@cloudoperators/juno-ui-components"
const HintLoading = ({ text, className }: any) => {
return (
<Stack alignment="center" className={className}>
<Spinner variant="primary" />
<Spinner variant="primary" className="mr-3" />
{text ? <span>{text}</span> : <span>Loading...</span>}
</Stack>
)
Expand Down
2 changes: 1 addition & 1 deletion apps/greenhouse/src/components/Auth.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const Auth = ({ children }: any) => {
<Stack alignment="center" distribution="center" direction="vertical" className="h-screen">
{authIsProcessing ? (
<>
<Spinner className="mx-6 mb-3" variant="primary" size="1.5rem"></Spinner>
<Spinner className="mx-6 mb-3 mr-3" variant="primary" size="1.5rem"></Spinner>
Signing on...
</>
) : (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const HintLoading = ({ text, centered }: any) => {
return (
<Stack {...stackProps}>
<Stack alignment="center">
<Spinner variant="primary" />
<Spinner variant="primary" className="mr-3" />
{text ? <span>{text}</span> : <span>Loading...</span>}
</Stack>
</Stack>
Expand Down
2 changes: 1 addition & 1 deletion apps/greenhouse/src/components/shared/HintLoading.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { Stack, Spinner } from "@cloudoperators/juno-ui-components"
const HintLoading = ({ text }: any) => {
return (
<Stack alignment="center">
<Spinner variant="primary" />
<Spinner variant="primary" className="mr-3" />
{text ? <span>{text}</span> : <span>Loading...</span>}
</Stack>
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import React, { HTMLProps, ReactNode } from "react"

const spinnerBaseStyles = `
jn:animate-spin
jn:mr-3
jn:h-5
jn:w-5
Comment thread
MartinS-git marked this conversation as resolved.
`
Expand Down
Loading