Skip to content

fix(ui): adjust dropdown icon right-gap in ComboBox and Select #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinS-git merged 8 commits into from
May 11, 2026
Merged

fix(ui): adjust dropdown icon right-gap in ComboBox and Select #1653

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5e724cd
fix(ui): adjust dropdown icon right-gap in ComboBox and Select
MartinS-git Apr 30, 2026
445a49b
chore(ui): add changeset for ComboBox and Select dropdown icon gap fix
MartinS-git Apr 30, 2026
81dfa23
fix(ui): fix input text overlap with toggle and valid/invalid icons i…
MartinS-git May 4, 2026
5c20489
fix(ui): rework ComboBox toggle button to use explicit borders
MartinS-git May 6, 2026
f784818
style(ui): restore original interface formatting in DateTimePicker an…
MartinS-git May 6, 2026
bd5a95b
style(ui): apply Prettier formatting to Select interface declaration
MartinS-git May 7, 2026
ce0ed83
style(ui): reformat Select interface with Prettier 3.8.3
MartinS-git May 7, 2026
ede80cc
refactor(ui): combine duplicate isValid/isInvalid checks in ComboBox
MartinS-git May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/fix-dropdown-icon-gap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@cloudoperators/juno-ui-components": patch
---

Fix dropdown icon right-gap in ComboBox and Select components to match Figma design specs.
Fix input text overlapping toggle button and valid/invalid icons by adding dynamic right padding.
19 changes: 10 additions & 9 deletions packages/ui-components/src/components/ComboBox/ComboBox.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const inputStyles = `
jn:text-base
jn:leading-4
jn:w-full
jn:px-4
jn:pl-4
jn:h-textinput
jn:text-left
jn:overflow-hidden
Expand Down Expand Up @@ -99,12 +99,12 @@ const buttonStyles = `
jn:absolute
jn:top-0
jn:right-0
jn:pr-2
jn:h-textinput
jn:w-6
jn:h-4
jn:w-8
jn:border-l-0
jn:border-y-[1px]
jn:border-r-[1px]
jn:border-y
jn:border-r
jn:rounded-tr
jn:rounded-br
jn:appearance-none
Expand Down Expand Up @@ -141,7 +141,7 @@ const menuStyles = `
const iconContainerStyles = `
jn:absolute
jn:top-[.4rem]
jn:right-6
jn:right-8
`

const centeredIconStyles = `
Expand Down Expand Up @@ -454,7 +454,8 @@ export const ComboBox = ({
${disabled ? disabledInputStyles : ""}
${isInvalid ? "juno-combobox-invalid " + invalidStyles : ""}
${isValid ? "juno-combobox-valid " + validStyles : ""}
${isValid || isInvalid ? "" : defaultBorderStyles}
${isValid || isInvalid ? "" : defaultBorderStyles}
${isValid || isInvalid ? "jn:pr-16" : "jn:pr-8"}
Comment thread
MartinS-git marked this conversation as resolved.
Outdated
${isLoading ? "juno-combobox-loading jn:cursor-not-allowed" : ""}
${hasError ? "juno-combobox-error jn:cursor-not-allowed" : ""}
${className}
Expand Down Expand Up @@ -489,12 +490,12 @@ export const ComboBox = ({
{!hasError && !isLoading ? (
<ComboboxButton
className={`
juno-combobox-toggle
juno-combobox-toggle
${buttonStyles}
${disabled ? disabledButtonStyles : ""}
${isInvalid ? "juno-combobox-toggle-invalid " + invalidButtonStyles : ""}
${isValid ? "juno-combobox-toggle-valid " + validButtonStyles : ""}
${isValid || isInvalid ? "" : defaultButtonStyles}
${isValid || isInvalid ? "" : defaultButtonStyles}
`}
>
<Icon icon={isOpen ? "expandLess" : "expandMore"} />
Expand Down
8 changes: 8 additions & 0 deletions packages/ui-components/src/components/DataGridToolbar/DataGridToolbar.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { Button } from "../Button"
import { NativeSelectOption } from "../NativeSelectOption"
import { NativeSelect } from "../NativeSelect"
import { InputGroup } from "../InputGroup"
import { PortalProvider } from "../PortalProvider"

const meta: Meta<typeof DataGridToolbar> = {
title: "Components/DataGrid/DataGridToolbar",
Expand Down Expand Up @@ -49,6 +50,13 @@ export const Default: Story = {
}

export const ComplexCustomLayout: Story = {
decorators: [
(Story) => (
<PortalProvider>
<Story />
</PortalProvider>
),
],
render: (args: DataGridToolbarProps) => (
<DataGridToolbar {...args}>
<Stack direction="horizontal" distribution="between">
Expand Down
3 changes: 2 additions & 1 deletion packages/ui-components/src/components/Select/Select.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ const toggleStyles = `
jn:h-[2.375rem]
jn:inline-flex
jn:items-center
jn:px-4
jn:pl-4
jn:pr-2
jn:rounded-3px
jn:select-none
jn:text-base
Expand Down
Loading