fix: refresh_mvCountIssueRatingsServiceId_proc#1187
Conversation
kanstantsinbuklis-sap
requested review from
MR2011,
copyonwrite,
dorneanu,
drochow and
michalkrzyz
as code owners
michalkrzyz
left a comment
michalkrzyz
left a comment
There was a problem hiding this comment.
Can we split this change to have clear view what was fixed? autocode change hides productivity...and it does not look better at all. I would not merge such changes.
michalkrzyz
left a comment
michalkrzyz
left a comment
There was a problem hiding this comment.
We should split this change. Please avoid combining fixes or redesigns with large-scale refactoring or auto-formatting.
Let's introduce a rule: no deep refactoring or formatting-only changes in the same PR as functional fixes.
When we fix or redesign something, there’s a real chance we may need to revert it. The more files and lines touched (especially by formatting changes), the harder and riskier that rollback becomes. It also makes code review and debugging significantly more difficult.
Please separate the functional changes from the formatting changes into distinct PRs.
I agree. Let's separate these changes please. |
kanstantsinbuklis-sap
force-pushed
the
kanstantsinbuklis-sap/issue-1177/fix-refresh-proc
branch
from
3224547 to
96cadfa
Compare
|
Removed formatting that was made by pre-commit hook |
| } | ||
| } | ||
|
|
||
| func (s *SqlDatabase) runPostMigrationCleanupRoutineInBackground(procs []string) { |
There was a problem hiding this comment.
this change most probably will corrupt some functionality. We need to keep this goroutine in background otherwise app will not start up until post migration is not done.
There was a problem hiding this comment.
Yeah, checked on the production dump and it takes lots of time, will return this goroutine
Signed-off-by: Kanstantsin Buklis <[email protected]>
kanstantsinbuklis-sap
force-pushed
the
kanstantsinbuklis-sap/issue-1177/fix-refresh-proc
branch
from
5dceb11 to
57764aa
Compare
Description
In this PR I've changed the kind of join from left to right because using left join in the result select we can get NULL
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Added to documentation?