feat(pluginpresets): expose PluginDefinition version in PluginPreset status#2076
Merged
Merged
Conversation
…status On-behalf-of: @SAP krzysztof.zagorski@sap.com Signed-off-by: Zaggy21 <k.zaggy@gmail.com>
2 tasks
github-actions
Bot
added
size/S
feature
core-apis
helm-charts
and removed
size/S
labels
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds visibility into which PluginDefinition version a PluginPreset references by persisting the version into PluginPreset.Status and exposing it via a kubectl print column, aligning with issue #1996’s goal of making the deployed/reference version quickly observable.
Changes:
- Add
status.pluginDefinitionVersiontoPluginPresetStatusand expose it as akubebuilderprint column. - Populate
PluginDefinitionVersionduring PluginPreset reconciliation by resolving the referenced (Cluster-)PluginDefinition spec. - Extend controller tests to assert that the status version is set.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/controller/plugin/pluginpreset_controller.go | Populate PluginDefinitionVersion in status during reconcile. |
| internal/controller/plugin/pluginpreset_controller_test.go | Add assertion that PluginDefinitionVersion is set as expected. |
| charts/manager/crds/greenhouse.sap_pluginpresets.yaml | Add printer column and schema property for status.pluginDefinitionVersion. |
| api/v1alpha1/pluginpreset_types.go | Add PluginDefinitionVersion field and printcolumn marker to the API type. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
Bot
added
size/M
documentation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Krzysztof Zagorski <k.zaggy@gmail.com>
abhijith-darshan
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds PluginDefinitionVersion to PluginPresetStatus. The field is populated on every reconcile and exposed as a print column.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Added to documentation?
Checklist