fix(charts): update alert conditions to bridge metrics gap#1981
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Helm chart versions and adjusts Prometheus alert rule expressions to better tolerate short-lived gaps in controller-emitted metrics (by using last_over_time(...)).
Changes:
- Bump
managerchart version to0.10.2and bumpgreenhousechart + dependency references accordingly. - Update several alert conditions to use
last_over_time(...[15m])to bridge metric staleness gaps.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/manager/Chart.yaml | Bumps the manager chart version. |
| charts/manager/alerts/resource.alerts | Updates owned-by label missing alert query to use last_over_time. |
| charts/manager/alerts/plugin.alerts | Updates plugin readiness alert query to use last_over_time. |
| charts/manager/alerts/organization.alerts | Updates organization/scim readiness alert queries to use last_over_time. |
| charts/manager/alerts/cluster.alerts | Updates multiple cluster-related alert queries to use last_over_time (and keeps token expiry aggregated). |
| charts/greenhouse/Chart.yaml | Bumps greenhouse chart version and updates manager dependency version. |
| charts/greenhouse/Chart.lock | Updates locked manager dependency version and regenerates digest/timestamp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
IvoGoman
force-pushed
the
fix/greenhouse/alerts
branch
from
8950675 to
24da0fe
Compare
abhijith-darshan
approved these changes
May 12, 2026
Signed-off-by: Ivo Gosemann <ivo.gosemann@sap.com>
IvoGoman
force-pushed
the
fix/greenhouse/alerts
branch
from
24da0fe to
10d255b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Copilot copilot@github.com
Signed-off-by: Ivo Gosemann ivo.gosemann@sap.com
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist