Skip to content

feat(pluginpresets): simple expression evaluation in PluginPreset #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
k-fabryczny wants to merge 2 commits into
base: main
Choose a base branch
from
+525 −0
Open

feat(pluginpresets): simple expression evaluation in PluginPreset #1934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60c890f
feat(pluginpresets): Simple expression evaluation in PluginPreset #1774
k-fabryczny Apr 21, 2026
bb54f83
fix(pluginpresets): fix formating
k-fabryczny Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/controller/plugin/pluginpreset_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,13 @@ func (r *PluginPresetReconciler) reconcilePluginPreset(ctx context.Context, pres

releaseName := getReleaseName(plugin, preset)

resolvedValues, err := r.resolveExpressionsForPreset(ctx, preset, &cluster)
Copy link
Copy Markdown
Contributor

@abhijith-darshan abhijith-darshan May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to hide it behind a feature toggle....

if err != nil {
return fmt.Errorf("failed to resolve option values for plugin %s: %w", plugin.Name, err)
}

plugin.Spec = preset.Spec.Plugin
plugin.Spec.OptionValues = resolvedValues
plugin.Spec.ReleaseName = releaseName
// Set the cluster name to the name of the cluster. The PluginSpec contained in the PluginPreset does not have a cluster name.
plugin.Spec.ClusterName = cluster.GetName()
Expand Down
Loading
Loading