fix(kube-monitoring): incorporate PrometheusRule with thanos-ruler label for absent-metrics-operator#1598
Open
sjentzschsap wants to merge 1 commit intocloudoperators:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the kube-monitoring plugin to handle PrometheusRules that are selected/managed by Thanos Ruler (i.e., labeled with thanos-ruler) by adjusting the default absentMetricsOperator.promRuleName template so it can derive the rule name from thanos-ruler when plugin/prometheus labels are absent.
Changes:
- Bump kube-monitoring
PluginDefinitionversion from12.1.0to12.1.1. - Extend
absentMetricsOperator.promRuleNamefallback order to:plugin→thanos-ruler→prometheus.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| kube-monitoring/plugindefinition.yaml | Bumps plugin version to reflect the behavior change. |
| kube-monitoring/charts/values.yaml | Updates the default rule-name template to support thanos-ruler-labeled PrometheusRules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…bel for absent-metrics-operator Signed-off-by: Soeren Jentzsch <soeren.jentzsch@sap.com>
sjentzschsap
force-pushed
the
fix/kube-monitoring-absent-metrics-thanos-ruler-labels
branch
from
98063a8 to
18f6e11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
The absent-metrics-operator logs errors and has issues processing PrometheusRules that include
thanos-rulerlabels, and neitherpluginnorprometheus. This is the case, when PrometheusRules are processed by Thanos Rule.According to the docs this is already the default, so let's not deviate here, and respect the
thanos-rulerlabels here too if present.