fix(opensearch): remove commented-out disabled alerts and service monitor#1597
Merged
fix(opensearch): remove commented-out disabled alerts and service monitor#1597
Conversation
…lerts Signed-off-by: joluc <[email protected]>
joluc
force-pushed
the
fix/opensearch-alerting
branch
from
51085e0 to
7d14355
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes Helm/YAML rendering issues in the OpenSearch extension by removing commented-out manifests that still contained Helm template directives (which Helm evaluates even when they appear inside YAML comments), and bumps the plugin/chart version to ship the fix.
Changes:
- Bump OpenSearch plugin and Helm chart versions from
0.0.58to0.0.59. - Remove disabled/commented-out operator ServiceMonitor template content that caused invalid YAML.
- Remove commented-out operator alert rules containing template directives, leaving an empty ruleset.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
opensearch/plugindefinition.yaml |
Bumps plugin and referenced chart version to 0.0.59. |
opensearch/chart/Chart.yaml |
Bumps Helm chart version to 0.0.59. |
opensearch/chart/templates/service-monitor-operator.yaml |
Removes commented-out ServiceMonitor template directives; template now renders nothing. |
opensearch/chart/alerts/opensearch-operator.yaml |
Removes commented-out operator alert rules with template directives; keeps rules: []. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Kuckkuck
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Commented-out alert rules and service monitor contain Go template directives that producing invalid YAML. Removed. Will come back in the next operator version.