Skip to content

Update heureka k8s assets scanner plugin definition#1594

Open
mdrkb wants to merge 1 commit intocloudoperators:mainfrom
mdrkb:heureka-scanner-k8s-assets-plugindefinition
Open

Update heureka k8s assets scanner plugin definition#1594
mdrkb wants to merge 1 commit intocloudoperators:mainfrom
mdrkb:heureka-scanner-k8s-assets-plugindefinition

Conversation

@mdrkb
Copy link
Copy Markdown
Contributor

@mdrkb mdrkb commented Apr 30, 2026

In production, heureka ComponentInstances are created with empty region, cluster, service label and support group label. The cronjob template referenced these values but they were never defined, causing them to render as empty strings. Additionally in Greenhouse dashboard, the compliance vulnerabilities cannot be filtered by service name or support group.

ToDo:

  • Add missing k8s_cluster_name, k8s_cluster_region, service_label and support_group_label keys to the k8s-assets-scanner plugin definition.
  • Update code owners for heureka related repos.

Copilot AI review requested due to automatic review settings April 30, 2026 13:12
@mdrkb mdrkb requested review from a team and dimtas as code owners April 30, 2026 13:12
@mdrkb mdrkb force-pushed the heureka-scanner-k8s-assets-plugindefinition branch from 9cc9711 to a0b4e40 Compare April 30, 2026 13:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the Heureka k8s assets scanner plugin definition to include missing configuration keys used by the cronjob template, and refreshes CODEOWNERS to reflect the current ownership of Heureka-related paths.

Changes:

  • Added missing cluster/service/support-group configuration keys to heureka-scanner-k8s-assets plugin definition.
  • Updated .github/CODEOWNERS for Heureka-related directories and scanners.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
heureka-scanner-k8s-assets/plugindefinition.yaml Declares additional scanner.* config keys so templates can render cluster/service/support-group metadata.
.github/CODEOWNERS Adjusts ownership for /heureka/ and Heureka scanner directories.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread heureka-scanner-k8s-assets/plugindefinition.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants