Update heureka k8s assets scanner plugin definition#1594
Open
mdrkb wants to merge 1 commit intocloudoperators:mainfrom
Open
Update heureka k8s assets scanner plugin definition#1594mdrkb wants to merge 1 commit intocloudoperators:mainfrom
mdrkb wants to merge 1 commit intocloudoperators:mainfrom
Conversation
9cc9711 to
a0b4e40
Compare
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Heureka k8s assets scanner plugin definition to include missing configuration keys used by the cronjob template, and refreshes CODEOWNERS to reflect the current ownership of Heureka-related paths.
Changes:
- Added missing cluster/service/support-group configuration keys to
heureka-scanner-k8s-assetsplugin definition. - Updated
.github/CODEOWNERSfor Heureka-related directories and scanners.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
heureka-scanner-k8s-assets/plugindefinition.yaml |
Declares additional scanner.* config keys so templates can render cluster/service/support-group metadata. |
.github/CODEOWNERS |
Adjusts ownership for /heureka/ and Heureka scanner directories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MR2011
approved these changes
May 4, 2026
dimtas
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In production, heureka
ComponentInstancesare created with empty region, cluster, service label and support group label. The cronjob template referenced these values but they were never defined, causing them to render as empty strings. Additionally in Greenhouse dashboard, the compliance vulnerabilities cannot be filtered by service name or support group.ToDo:
k8s_cluster_name,k8s_cluster_region,service_labelandsupport_group_labelkeys to thek8s-assets-scannerplugin definition.