Feature/1 merge blueprint versions #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also fixes some minor typos, adds doc comments and moves some higher-level definitions into bpcore since v2 will probably make use of those as well.
This reverts commit 060654f.
This import was meant to compile as-is but some changes were necessary to make it compile without domain or kubernetes package references. Long story short, I needed to change a lot of things
This was changed during the extraction and was most likely a mistake. The original code used string here.
This was changed during the extraction and was most likely a mistake. The original code used string here.
This was changed during the extraction and was most likely a mistake. The original code used string here.
Somehow these functions seem to be necessary by the blueprint operator's deep copy generator even though I do not see where I might have deleted it
# Conflicts: # go.mod
These functions modified the input instead of the output. This commit changes this so that the output is actually copied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1 and moves blueprint related structs and high-level functionality from the cloudogu/k8s-blueprint-operator#103 here so other blueprint consuming clients can do so with a certain level of abstraction from the operator.
This code originated in cloudogu/blueprint-lib#1 but moves here because further development and refactoring can happen without two rather different code bases (from cesapp and the blueprint operator) to interfere. A two-repo way was specifically chosen over a mono-repo with two Go modules in it. This all to avoid different release strategies and manual mistakes in PR target branch selection (v1 -> a v1 branch/tag while develop -> v2).