Fix: Correctly tag architecture for ARM Docker image #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyosuke Miyamura <[email protected]>
386jp
requested review from
NiccoloFei,
fcanovai,
gbartolini,
jbattiato,
litaocdl,
mnencia and
sxd
as code owners
|
@386jp can you please verify that the new images work? We have just changed the way we build them. Please refer to the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that cnpg's postgis container for ARM is tagged as
unknown/unknownin GHCR, which result in ImagePullBackOff error when we use postgis in ARM node.Since v4.0.0 of docker/build-push-action, provenance mode is on by default. By turning it off, we can correctly tag architecture for all architectures, including ARM.
This is my first time contributing to this repo, so if there is anything missing, please let me know.